Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: the gif tutorial in the GIT config modal is going out of screen bounds #36586

Closed
1 task done
kamakshibhat-appsmith opened this issue Sep 27, 2024 · 0 comments · Fixed by #36589
Closed
1 task done

[Bug]: the gif tutorial in the GIT config modal is going out of screen bounds #36586

kamakshibhat-appsmith opened this issue Sep 27, 2024 · 0 comments · Fixed by #36589
Labels
Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Regressed Scenarios that were working before but have now regressed

Comments

@kamakshibhat-appsmith
Copy link

kamakshibhat-appsmith commented Sep 27, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

the gif tutorial in the GIT config modal is going out of screen bounds .
due to this, the CTAs are inaccessible unless the gif tutorial is collapsed

this is happening on latest chrome version:
My version:
129.0.6668.71

Steps To Reproduce

Current :
Screenshot 2024-09-27 at 1 25 58 PM

Previously and expectation(you can see the scroll bar )
Screenshot 2024-09-27 at 1 56 50 PM

Device: 13' mac, 1440*667

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud/Self-hosted
@kamakshibhat-appsmith kamakshibhat-appsmith added Bug Something isn't working Production Regressed Scenarios that were working before but have now regressed Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX Git Platform Issues related to the git & the app platform labels Sep 27, 2024
@github-actions github-actions bot removed Git Platform Issues related to the git & the app platform labels Sep 27, 2024
@nidhi-nair nidhi-nair added the Git Product Issues related to version control product label Sep 27, 2024
@github-actions github-actions bot added the Git Platform Issues related to the git & the app platform label Sep 27, 2024
@brayn003 brayn003 mentioned this issue Sep 27, 2024
Merged
2 tasks
brayn003 added a commit that referenced this issue Sep 30, 2024
@brayn003
fix: fixing modal height by removing min-content (#36589)
138cb79 
## Description
min-content css property is behaving weirdly in the latest update of the
chrome browser

Fixes #36586

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11084506553>
> Commit: a888acf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11084506553&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Sat, 28 Sep 2024 14:34:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Removed the minimum height constraint from the modal body, allowing
for more flexible vertical space allocation in the modal display.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Sep 30, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Regressed Scenarios that were working before but have now regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixing modal height by removing min-content appsmithorg/appsmith
3 participants
@nidhi-nair @appsmith-bot @kamakshibhat-appsmith