Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get NIOEmbedded clean under strict concurrency #3030

Merged
merged 7 commits into from
Dec 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compile on 5.9
Lukasa committed Dec 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 0dd4625eeda05e460d6bd36d6b90072448d591ea
7 changes: 6 additions & 1 deletion Sources/NIOEmbedded/AsyncTestingChannel.swift
Original file line number Diff line number Diff line change
@@ -201,10 +201,15 @@ public final class NIOAsyncTestingChannel: Channel {

// These two variables are only written once, from a single thread, and never written again, so they're _technically_ thread-safe. Most methods cannot safely
// be used from multiple threads, but `isActive`, `isOpen`, `eventLoop`, and `closeFuture` can all safely be used from any thread. Just.
#if compiler(>=5.10)
@usableFromInline
nonisolated(unsafe) var channelcore: EmbeddedChannelCore!

nonisolated(unsafe) private var _pipeline: ChannelPipeline!
#else
@usableFromInline
var channelcore: EmbeddedChannelCore!
private var _pipeline: ChannelPipeline!
#endif

private struct State {
var isWritable: Bool