Get NIOEmbedded clean under strict concurrency #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NIOEmbedded is used all over NIO-land for testing various pieces of the infrastructure, and so requires a substantial audit for strict concurrency. Modifications: - Mark a few things Sendable. - Fix the tests, which actually did have some nasty bugs Result: Sendable-clean NIOEmbedded
FranzBusch
approved these changes
Dec 16, 2024
|
API breakage is expected. |
glbrntt
approved these changes
Dec 17, 2024
finagolfin
added a commit
to finagolfin/swift-nio
that referenced
this pull request
Dec 18, 2024
Pull apple#3030 invokes C APIs that aren't in the extremely limited Bionic module, so import the much larger Android overlay instead.
Lukasa
pushed a commit
that referenced
this pull request
Dec 18, 2024
Pull #3030 invokes C APIs that aren't in the extremely limited Bionic module, so import the much larger Android overlay instead. This [just broke my daily Android CI](https://github.com/finagolfin/swift-android-sdk/actions/runs/12389744616/job/34583381415#step:19:239).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIOEmbedded is used all over NIO-land for testing various pieces of the infrastructure, and so requires a substantial audit for strict concurrency.
Modifications:
Result:
Sendable-clean NIOEmbedded