Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: website design uplift #2872
base: master
Are you sure you want to change the base?
docs: website design uplift #2872
Changes from all commits
5e5f937
67a75d2
2c8d966
89e31d2
5e4eedc
97357bc
c676a32
c70965c
c79c6ab
70db3b0
a99f877
7c32c7a
11331ec
3893ff3
f1871cf
bcac624
d8c8c8a
0c28c83
0787a67
fbb52e1
f2078b3
083e8aa
722b423
d90ed0e
05b08c1
6ae3c43
162ceae
7a9e56c
c76831b
b826212
ad5046e
eac42f0
4cd595f
73c1bec
7da5e44
2d54cac
82f051c
9de6e99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be actually a clickable card element, here are defined the hover states for the cards and each section should lead to a specific docs part. I will ask Banán, where it should exactly lead 🙏

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, shouldn't we also use the action links as in the cards below, to indicate it is clickable?

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, it is different kind of element and the clickable indication should be the hover state 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the fonts feel a bit thicker then in designs but in code the font-weight is correct, do you know what could be the problem? If not we can let it be 🤓


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably depends on the font files we're using. I remember we had a similar issue in web and it was solved by using a different font file.
In the code we have some font definitions like this:
So I suppose the Lota.woff file we have is for a 600 thickness. We should change the file or add a file for a 400 thickness. If you feel like this is important, could you find us the lota.woff (and lota.woff2) files that have the correct thickness, or tell us where to find them? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, let's release it without the 400 weight and I will check if we can find something and we can possibly change it next week ✨