Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: website design uplift #2872

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

webrdaniel
Copy link
Collaborator

@webrdaniel webrdaniel commented Mar 5, 2025

Deployed here: https://webrdaniel.github.io/:
It is not possible to navigate to the updated /python page as it lives in different repo.

Changes:

  • navigation header (different on index page and javascript pages)
  • footer
  • search modal
  • new index page
  • new /js page

TODO:
I have not found which links to use for the buttons on the landing page and header, so I just used some that make sense to me. But please check if they are really correct.

Figma design files are here

Content file: https://www.notion.so/apify/Crawlee-homepage-value-props-12af39950a2280d29d20edb080b2ece9?pvs=4

@github-actions github-actions bot added this to the 109th sprint - Web Team milestone Mar 5, 2025
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Mar 5, 2025
Closes apify/apify-web#4504

---------

Co-authored-by: katzino <[email protected]>
Co-authored-by: Daniel Wébr <[email protected]>
@webrdaniel webrdaniel marked this pull request as ready for review March 6, 2025 15:18
@webrdaniel webrdaniel requested review from baldasseva and rezaczu March 6, 2025 15:19
@webrdaniel webrdaniel requested a review from diodames March 7, 2025 10:40
@diodames
Copy link

diodames commented Mar 7, 2025

Hey, great work!
Few things. The code snippet horizontal scroll seems unnecessary (attached screenshot).
Screenshot 2025-03-07 at 11 44 25

On the /Javascript page the code snippet of the benefits seems the spacing of the elements inside is a bit too much.
Screenshot 2025-03-07 at 11 44 54

Probably similar issue below it (attached), can we not have it scrollable maybe so the code fits the text area?
Screenshot 2025-03-07 at 11 46 02

@diodames
Copy link

diodames commented Mar 7, 2025

One more thing that I noticed, it seems like when I click on the menu it's hard to read the text (attached) screenshot, not sure why I see it that way. Specifically the /Javascript and /Python
Screenshot 2025-03-07 at 11 47 44

@webrdaniel
Copy link
Collaborator Author

Updated the code blocks by decreasing the paddings and spacings.
Unfortunetely those does not support wrapping the text to the next line to prevent the scrolling.
We can add some custom css but it wont look good because of the various indents.

@katzino
Copy link
Collaborator

katzino commented Mar 7, 2025

Logo dropdown jumps during initial page laod

Screen.Recording.2025-03-07.at.13.16.47.mov

@katzino
Copy link
Collaborator

katzino commented Mar 7, 2025

Those circles get shrunk by 2px

Screen.Recording.2025-03-07.at.13.19.59.mov

@webrdaniel
Copy link
Collaborator Author

@rezaczu did some fixes. It would be quite hard to do the closing menu if clicking on the item you are currently on, so I left that is it is.

@katzino
Copy link
Collaborator

katzino commented Mar 10, 2025

super nit, but there is an inconsistency in how boolean value is highlighted 🧐
Screenshot 2025-03-10 at 10 22 28
Screenshot 2025-03-10 at 10 22 16

@B4nan
Copy link
Member

B4nan commented Mar 10, 2025

regarding this particular example, nowadays you can as well use string literals instead of the enum values to make it less wide

fingerprintOptions: {
    fingerprintGeneratorOptions: {
        operatingSystems: ['windows'],
        browsers: ['chrome'],
        devices: ['desktop'],
    },
},

@webrdaniel webrdaniel requested review from adelamikk and mnmkng and removed request for diodames March 11, 2025 13:57
Copy link

@adelamikk adelamikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks lot! ❤️ I have just few comments ✨

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be actually a clickable card element, here are defined the hover states for the cards and each section should lead to a specific docs part. I will ask Banán, where it should exactly lead 🙏
Screenshot 2025-03-11 at 16 39 14

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, shouldn't we also use the action links as in the cards below, to indicate it is clickable?
Screenshot 2025-03-12 at 8 20 26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, it is different kind of element and the clickable indication should be the hover state 🙏

@webrdaniel webrdaniel requested a review from adelamikk March 12, 2025 08:43
Copy link
Member

@mnmkng mnmkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! ❤️ Sorry, I did not read the whole conversation (and did not check the whole website 😅), but a few things I noticed:

On the master page:

  • when I change the code example to python
    • there's no run on apify button
    • the install command below the code example doesn't change to pip install
  • the animation is very nice, but it's kinda blurry on Chrome, and it's megablurry on Safari

On the JS page:

  • the code examples look kinda awkward when there's such a big gap of whitespace below them, can we fix this somehow? Maybe if there's no "good" way of doing it, we could at least try aligning the top of the example with the top of the heading to see if it looks better?

Thanks! Looking forward to seeing this live.

Copy link

@rezaczu rezaczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this in Safari’s tab overview-some circles appear around the animation. It doesn’t break the web or anything, so just a visual nit. Only flagging in case we want to look into it. 🙏🏻
image

Copy link

@adelamikk adelamikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed few more last nits, but we are getting there ❤️ Thanks a lot!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the fonts feel a bit thicker then in designs but in code the font-weight is correct, do you know what could be the problem? If not we can let it be 🤓
Screenshot 2025-03-13 at 9 40 22
Screenshot 2025-03-13 at 9 41 44

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It probably depends on the font files we're using. I remember we had a similar issue in web and it was solved by using a different font file.
In the code we have some font definitions like this:

@font-face {
    font-family: 'Lota Grotesque';
    src:
        url('/font/lota.woff2') format('woff2'),
        url('/font/lota.woff') format('woff');
    font-weight: 600;
}

So I suppose the Lota.woff file we have is for a 600 thickness. We should change the file or add a file for a 400 thickness. If you feel like this is important, could you find us the lota.woff (and lota.woff2) files that have the correct thickness, or tell us where to find them? Thanks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, let's release it without the 400 weight and I will check if we can find something and we can possibly change it next week ✨

@baldasseva baldasseva requested a review from adelamikk March 13, 2025 13:43
@webrdaniel
Copy link
Collaborator Author

I've changed the way we insert the animated logo so it is no longer blurry in Safari.
But now it is lagging on safari 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants