-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: website design uplift #2872
base: master
Are you sure you want to change the base?
Conversation
Closes apify/apify-web#4504 --------- Co-authored-by: katzino <[email protected]> Co-authored-by: Daniel Wébr <[email protected]>
Updated the code blocks by decreasing the paddings and spacings. |
Logo dropdown jumps during initial page laod Screen.Recording.2025-03-07.at.13.16.47.mov |
Those circles get shrunk by 2px Screen.Recording.2025-03-07.at.13.19.59.mov |
@rezaczu did some fixes. It would be quite hard to do the closing menu if clicking on the item you are currently on, so I left that is it is. |
regarding this particular example, nowadays you can as well use string literals instead of the enum values to make it less wide fingerprintOptions: {
fingerprintGeneratorOptions: {
operatingSystems: ['windows'],
browsers: ['chrome'],
devices: ['desktop'],
},
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks lot! ❤️ I have just few comments ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, it is different kind of element and the clickable indication should be the hover state 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! ❤️ Sorry, I did not read the whole conversation (and did not check the whole website 😅), but a few things I noticed:
On the master page:
- when I change the code example to python
- there's no run on apify button
- the install command below the code example doesn't change to pip install
- the animation is very nice, but it's kinda blurry on Chrome, and it's megablurry on Safari
On the JS page:
- the code examples look kinda awkward when there's such a big gap of whitespace below them, can we fix this somehow? Maybe if there's no "good" way of doing it, we could at least try aligning the top of the example with the top of the heading to see if it looks better?
Thanks! Looking forward to seeing this live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed few more last nits, but we are getting there ❤️ Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

It probably depends on the font files we're using. I remember we had a similar issue in web and it was solved by using a different font file.
In the code we have some font definitions like this:
@font-face {
font-family: 'Lota Grotesque';
src:
url('/font/lota.woff2') format('woff2'),
url('/font/lota.woff') format('woff');
font-weight: 600;
}
So I suppose the Lota.woff file we have is for a 600 thickness. We should change the file or add a file for a 400 thickness. If you feel like this is important, could you find us the lota.woff (and lota.woff2) files that have the correct thickness, or tell us where to find them? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, let's release it without the 400 weight and I will check if we can find something and we can possibly change it next week ✨
…to feat/design-uplift-2025
I've changed the way we insert the animated logo so it is no longer blurry in Safari. |
…awlee into feat/design-uplift-2025
Deployed here: https://webrdaniel.github.io/:
It is not possible to navigate to the updated
/python
page as it lives in different repo.Changes:
TODO:
I have not found which links to use for the buttons on the landing page and header, so I just used some that make sense to me. But please check if they are really correct.
Figma design files are here
Content file: https://www.notion.so/apify/Crawlee-homepage-value-props-12af39950a2280d29d20edb080b2ece9?pvs=4