ZOOKEEPER-2623: [ADDENDUM] Forbid OpCode.check outside OpCode.multi #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Individual `OpCode.check` will get `UnimplementedException`.
kezhuw
force-pushed
the
ZOOKEEPER-2623-addendum-forbid-opcode-check-outside-multi
branch
from
dc22ba8 to
6d1725b
Compare
hezhangjian
approved these changes
May 23, 2024
tisonkun
reviewed
Jun 12, 2024
Comment on lines
298
to
+299
| case OpCode.check: | ||
| return false; |
There was a problem hiding this comment.
This is the effective change beyond the revert. According to https://lists.apache.org/thread/vl816jfrklvqz29coz5qnwpom9q41pcg.
tisonkun
approved these changes
Jun 12, 2024
kezhuw
added a commit
to kezhuw/zookeeper
that referenced
this pull request
Aug 12, 2024
Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
kezhuw
added a commit
to kezhuw/zookeeper
that referenced
this pull request
Aug 12, 2024
Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
kezhuw
added a commit
to kezhuw/zookeeper
that referenced
this pull request
Aug 12, 2024
Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
kezhuw
added a commit
that referenced
this pull request
Aug 13, 2024
kezhuw
added a commit
that referenced
this pull request
Aug 13, 2024
kezhuw
deleted the
ZOOKEEPER-2623-addendum-forbid-opcode-check-outside-multi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
OpCode.checkwill getUnimplementedException.JIRA: ZOOKEEPER-2623
Discussion thread: https://lists.apache.org/thread/vl816jfrklvqz29coz5qnwpom9q41pcg
This pr reworks/reverts #1988, which return an empty response for individual
OpCode.check, for the following reasons:OpCode.checkis covered byOpCode.exists.Open this pr for easy evaluation. I will reply the discussion thread for reference.
I plan to open a draft backport on branch-3.9 to ease code review if we are willing to go this direction.