Backport to branch-3.8: ZOOKEEPER-2623: Forbid OpCode.check outside OpCode.multi #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
|
I plan to backport ZOOKEEPER-2623 to branch-3.8 as the fix is quite simple and the bug could cause server crash(as the jira reported) and unrecognized database txn(as the test confirmed). #2105 backports it to branch-3.9. |
tisonkun
approved these changes
Aug 12, 2024
|
@kezhuw Looks like the jira ticket is out-of-date: it mentions 3.10.0 as fix version, but this PR backported it to 3.8. Please fix. |
kezhuw
deleted the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
OpCode.checkwill getUnimplementedException.This is a squashed backport of several commits from master: