Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete modal button with lowercase text #30060

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: Delete modal button with lowercase text #30060

merged 2 commits into from
Aug 30, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adjust the text of the delete modal button.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

rusackas
rusackas approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! :D

@michael-s-molina michael-s-molina merged commit cd6b8b2 into apache:master Aug 30, 2024
34 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 6, 2024
@michael-s-molina @sadpandajoe
fix: Delete modal button with lowercase text (#30060)
d43e992 
(cherry picked from commit cd6b8b2)
sadpandajoe pushed a commit that referenced this pull request Sep 6, 2024
@michael-s-molina @sadpandajoe
fix: Delete modal button with lowercase text (#30060)
4581606 
(cherry picked from commit cd6b8b2)
sadpandajoe pushed a commit that referenced this pull request Sep 6, 2024
@michael-s-molina @sadpandajoe
fix: Delete modal button with lowercase text (#30060)
e8d5ff1 
(cherry picked from commit cd6b8b2)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

@kgabryje kgabryje Awaiting requested review from kgabryje

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @rusackas @sadpandajoe