fix: Delete modal button with lowercase text (#30060)

apache · Aug 30, 2024 · cd6b8b2 · cd6b8b2
1 parent 1f2f66b
commit cd6b8b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/superset-frontend/src/components/ConfirmStatusChange/ConfirmStatusChange.test.jsx b/superset-frontend/src/components/ConfirmStatusChange/ConfirmStatusChange.test.jsx
@@ -58,7 +58,7 @@ test('calls the function on confirm', async () => {
   const confirmInput = getByTestId('delete-modal-input');
   fireEvent.change(confirmInput, { target: { value: 'DELETE' } });
 
-  const confirmButton = getByRole('button', { name: 'delete' });
+  const confirmButton = getByRole('button', { name: 'Delete' });
   fireEvent.click(confirmButton);
 
   await waitFor(() => expect(mockedProps.onConfirm).toHaveBeenCalledTimes(1));

diff --git a/superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx b/superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx
@@ -77,12 +77,12 @@ test('Calling "onConfirm" only after typing "delete" in the input', () => {
   expect(props.onConfirm).toBeCalledTimes(0);
 
   // do not execute "onConfirm" if you have not typed "delete"
-  userEvent.click(screen.getByText('delete'));
+  userEvent.click(screen.getByText('Delete'));
   expect(props.onConfirm).toBeCalledTimes(0);
 
   // execute "onConfirm" if you have typed "delete"
   userEvent.type(screen.getByTestId('delete-modal-input'), 'delete');
-  userEvent.click(screen.getByText('delete'));
+  userEvent.click(screen.getByText('Delete'));
   expect(props.onConfirm).toBeCalledTimes(1);
 
   // confirm input has been cleared

diff --git a/superset-frontend/src/components/DeleteModal/index.tsx b/superset-frontend/src/components/DeleteModal/index.tsx
@@ -80,7 +80,7 @@ export default function DeleteModal({
       disablePrimaryButton={disableChange}
       onHide={hide}
       onHandledPrimaryAction={confirm}
-      primaryButtonName={t('delete')}
+      primaryButtonName={t('Delete')}
       primaryButtonType="danger"
       show={open}
       title={title}