feat(db_engine_specs): added support for Denodo Virtual DataPort (Superset 4.0 branch)

[denodo-research-labs]

SUMMARY

Following up on #20656, this PR adds basic support for connecting to Denodo Virtual DataPort (aka VDP Server) from Superset 4.0.x.

This includes:

• A Denodo DB Engine Spec (in superset/db_engine_specs/denodo.py).
• Version configuration for the companion SQLAlchemy dialect (in setup.py).
• Changes to the documentation in order to mention the new support (in docs/docs/databases/*).

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[codecov]

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (5de4862) to head (ed217cf).
Report is 61 commits behind head on 4.0.

Files	Patch %	Lines
superset/db_engine_specs/denodo.py	80.64%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##              4.0   #29926       +/-   ##
===========================================
+ Coverage   69.65%   83.14%   +13.48%     
===========================================
  Files        1910      512     -1398     
  Lines       74936    36101    -38835     
  Branches     8425        0     -8425     
===========================================
- Hits        52200    30017    -22183     
+ Misses      20671     6084    -14587     
+ Partials     2065        0     -2065     

Flag	Coverage Δ
hive	48.94% <80.64%> (?)
javascript	?
mysql	77.95% <80.64%> (-0.07%)	⬇️
postgres	78.08% <80.64%> (-0.06%)	⬇️
presto	53.68% <80.64%> (-0.01%)	⬇️
python	83.14% <80.64%> (+0.18%)	⬆️
sqlite	77.52% <80.64%> (?)
unit	56.73% <80.64%> (+0.24%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

Code LGTM, cool to see yet another new db engine! owever I'm curious if we really need to rejig those sidebar_position entries every time we add a new entry that's not at the end of the list? @rusackas do you know?

[villebro]

@denodo-research-labs please check the failing CI checks (probably minor linting issues)

[michael-s-molina]

@denodo-research-labs Thanks for your contribution. Would you mind point to master instead of 4.0 branch? Otherwise this feature will get dropped in future releases.

Also, 4.0 cannot accept features. It would require a minor release such as 4.1, 4.2, etc.

[denodo-research-labs]

Would you mind point to master instead of 4.0 branch? Otherwise this feature will get dropped in future releases.

There are two PRs, we created #29927 for master.

[denodo-research-labs]

Also, 4.0 cannot accept features. It would require a minor release such as 4.1, 4.2, etc.

We are now adding modifications to the PR for 4.1 in master (#29927). We assume this one for 4.0 should be abandoned, right? In such case, please feel free to close this one when suitable.

[michael-s-molina]

We are now adding modifications to the PR for 4.1 in master (#29927).

@denodo-research-labs Ideally, you would only merge this to master and let the release manager determine in which minor version this should be included. For 4.1, the release manager is @sadpandajoe.