-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Denodo DB in Superset (sqlalchemy dialect already exists) #20656
Comments
@zyystudio @srinify Is there any interest on this? How could I contribute a pull request? Do I need to add a SIP first? Superset is now using sql-alchemy 1.4 so this should work quite easily. |
Seems like all that's needed here is a Documentation PR and/or package addition. Anyone willing to provide this? Tempted to close it as stale and because it's a feature request rather than a bug. But I'm hoping this thread can still provoke a contribution. No SIP needed :) |
Please note we are actively looking at contributing a DB Engine Spec for Denodo to the Superset repository. We will report ASAP :) |
@denodo-research-labs let us know if you're still interested in contributing that. We'd love to see it. Otherwise we might close this issue soon as stale, and because it's more feature request than bug report ;) |
We are actually adapting our infrastructure to 4.0 and 4.1 and intended to create a PR in a matter of days. It would include:
In order to do the latter, we did the following in our internal fork:
But also, we needed to do this in #> [denodo-removed]
# RUN --mount=type=bind,target=./requirements/base.txt,src=./requirements/base.txt \
# --mount=type=bind,target=./requirements/docker.txt,src=./requirements/docker.txt \
# --mount=type=cache,target=/root/.cache/pip \
# pip install -r requirements/docker.txt
#> ----
#> [denodo-added]
RUN python -m pip install --upgrade pip
RUN cd /app \
&& pip install --no-cache -r requirements/docker.txt \
&& pip install --no-cache -r requirements/local.txt || true
#> ---- Are we installing this dependency properly, would you advise a different approach? Any further instructions about how to prepare our artifacts for the PR? |
We have just added two Pull Requests:
|
Hi,
Per https://superset.apache.org/docs/databases/installing-database-drivers/ bottom, I submit it here.
Denodo is the data virtualization market leader per Gartner and Forrester.
Please refer to
https://community.denodo.com/docs/html/document/denodoconnects/8.0/en/Denodo%20Dialect%20for%20SQLAlchemy%20-%20User%20Manual
There is a dedicated entry "Apache Superset Installation"
Thanks
Stanley Zhang
The text was updated successfully, but these errors were encountered: