Add support for Denodo DB in Superset (sqlalchemy dialect already exists)

[zyystudio]

Hi,
Per https://superset.apache.org/docs/databases/installing-database-drivers/ bottom, I submit it here.
Denodo is the data virtualization market leader per Gartner and Forrester.
Please refer to
https://community.denodo.com/docs/html/document/denodoconnects/8.0/en/Denodo%20Dialect%20for%20SQLAlchemy%20-%20User%20Manual
There is a dedicated entry "Apache Superset Installation"
Thanks
Stanley Zhang

[buggythepirate]

@zyystudio @srinify Is there any interest on this? How could I contribute a pull request? Do I need to add a SIP first? Superset is now using sql-alchemy 1.4 so this should work quite easily.

[rusackas]

Seems like all that's needed here is a Documentation PR and/or package addition. Anyone willing to provide this? Tempted to close it as stale and because it's a feature request rather than a bug. But I'm hoping this thread can still provoke a contribution. No SIP needed :)

[denodo-research-labs]

Please note we are actively looking at contributing a DB Engine Spec for Denodo to the Superset repository. We will report ASAP :)

[rusackas]

@denodo-research-labs let us know if you're still interested in contributing that. We'd love to see it. Otherwise we might close this issue soon as stale, and because it's more feature request than bug report ;)

[denodo-research-labs]

We are actually adapting our infrastructure to 4.0 and 4.1 and intended to create a PR in a matter of days. It would include:

• The db_engine_spec (denodo.py)
• The instalaltion of our denodo-sqalchemy package

In order to do the latter, we did the following in our internal fork:

• Add the version specification of the dependency in setup.py
• Added the dependency in requirements/local.in and requirements/local.txt

But also, we needed to do this in Dockerfile in order for this dependency to be installed correctly, because we didn't find local.txt to be taken into account:

#> [denodo-removed]
# RUN --mount=type=bind,target=./requirements/base.txt,src=./requirements/base.txt \
#     --mount=type=bind,target=./requirements/docker.txt,src=./requirements/docker.txt \
#     --mount=type=cache,target=/root/.cache/pip \
#     pip install -r requirements/docker.txt
#> ----

#> [denodo-added]
RUN python -m pip install --upgrade pip
RUN cd /app \
    && pip install --no-cache -r requirements/docker.txt \
    && pip install --no-cache -r requirements/local.txt || true
#> ----

Are we installing this dependency properly, would you advise a different approach?

Any further instructions about how to prepare our artifacts for the PR?

[denodo-research-labs]

We have just added two Pull Requests:

• feat(db_engine_specs): added support for Denodo Virtual DataPort (Superset 4.0 branch) #29926 created for Superset 4.0.x (4.0 branch)
• feat(db_engine_specs): added support for Denodo Virtual DataPort #29927 created for Superset 4.1.x (master branch)