chore: Default to engine specification regarding using wildcard

[john-bodley]

SUMMARY

The BaseEngineSpec.select_star method provides an option (with a default) with regards to whether or not one should use a wildcard (show_cols=False) or enumerate the columns (show_cols=True) when generating a SQL statement for fetching sample records from a dataset.

Some of the underlying engines—Hive, Presto, BigQuery—override this method including the default for the show_cols function argument. When creating the SQL statement rather than forcing show_cols=True we should instead fallback to the engine specific preference.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.99%. Comparing base (5e8459b) to head (1a52e52).
Report is 100 commits behind head on master.

Files	Patch %	Lines
superset/databases/api.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27843      +/-   ##
==========================================
- Coverage   67.46%   59.99%   -7.48%     
==========================================
  Files        1910     1912       +2     
  Lines       74802    75019     +217     
  Branches     8345     8345              
==========================================
- Hits        50467    45007    -5460     
- Misses      22284    27961    +5677     
  Partials     2051     2051              

Flag	Coverage Δ
hive	48.93% <0.00%> (?)
mysql	?
postgres	?
presto	53.63% <0.00%> (?)
python	62.76% <0.00%> (-15.51%)	⬇️
sqlite	?
unit	56.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.99%. Comparing base (5e8459b) to head (1a52e52).
Report is 114 commits behind head on master.

Files	Patch %	Lines
superset/databases/api.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27843      +/-   ##
==========================================
- Coverage   67.46%   59.99%   -7.48%     
==========================================
  Files        1910     1912       +2     
  Lines       74802    75019     +217     
  Branches     8345     8345              
==========================================
- Hits        50467    45007    -5460     
- Misses      22284    27961    +5677     
  Partials     2051     2051              

Flag	Coverage Δ
hive	48.93% <0.00%> (?)
mysql	?
postgres	?
presto	53.63% <0.00%> (?)
python	62.76% <0.00%> (-15.51%)	⬇️
sqlite	?
unit	56.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[betodealmeida]

👍🏼

[michael-s-molina]

Nice. Thanks for fixing this @john-bodley.