chore: Default to engine specification regarding using wildcard

apache · Apr 1, 2024 · e40cb90 · e40cb90
1 parent 5e8459b
commit e40cb90
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/superset/databases/api.py b/superset/databases/api.py
@@ -865,7 +865,7 @@ def select_star(
         self.incr_stats("init", self.select_star.__name__)
         try:
             result = database.select_star(
-                table_name, schema_name, latest_partition=True, show_cols=True
+                table_name, schema_name, latest_partition=True
             )
         except NoSuchTableError:
             self.incr_stats("error", self.select_star.__name__)

diff --git a/superset/databases/utils.py b/superset/databases/utils.py
@@ -92,7 +92,6 @@ def get_table_metadata(
         "selectStar": database.select_star(
             table_name,
             schema=schema_name,
-            show_cols=True,
             indent=True,
             cols=columns,
             latest_partition=True,

diff --git a/tests/integration_tests/databases/api_tests.py b/tests/integration_tests/databases/api_tests.py
@@ -1479,7 +1479,7 @@ def test_get_invalid_table_table_metadata(self):
                     "indexes": [],
                     "name": "wrong_table",
                     "primaryKey": {"constrained_columns": None, "name": None},
-                    "selectStar": "SELECT\nFROM wrong_table\nLIMIT 100\nOFFSET 0",
+                    "selectStar": "SELECT *\nFROM wrong_table\nLIMIT 100\nOFFSET 0",
                 },
             )
         elif example_db.backend == "mysql":

diff --git a/tests/integration_tests/db_engine_specs/presto_tests.py b/tests/integration_tests/db_engine_specs/presto_tests.py
@@ -867,16 +867,14 @@ def test_select_star_presto_expand_data(
             {"column_name": "val.2"},
             {"column_name": ".val2."},
         ]
-        PrestoEngineSpec.select_star(
-            database, table_name, engine, show_cols=True, cols=cols
-        )
+        PrestoEngineSpec.select_star(database, table_name, engine, cols=cols)
         mock_select_star.assert_called_once_with(
             database,
             table_name,
             engine,
             None,
             100,
-            True,
+            False,
             True,
             True,
             [