Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update migration chart_ds_constraint to have seperate batch op #23942

Merged
merged 1 commit into from
May 4, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 4, 2023

SUMMARY

Getting errors for constraint in same batch operation, so refactoring to commit before adding a new constraint

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh requested a review from a team as a code owner May 4, 2023 18:14
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #23942 (149c76c) into master (3dc4de4) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 149c76c differs from pull request most recent head 53bb6ed. Consider uploading reports for the commit 53bb6ed to get more accurate results

@@            Coverage Diff             @@
##           master   #23942      +/-   ##
==========================================
+ Coverage   67.98%   68.12%   +0.13%     
==========================================
  Files        1941     1941              
  Lines       75073    75073              
  Branches     8155     8155              
==========================================
+ Hits        51041    51141     +100     
+ Misses      21949    21849     -100     
  Partials     2083     2083              
Flag Coverage Δ
hive 53.00% <ø> (?)
mysql 78.82% <ø> (?)
postgres 78.89% <ø> (ø)
presto 52.92% <ø> (ø)
python 82.68% <ø> (+0.27%) ⬆️
sqlite 77.41% <ø> (?)
unit 52.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang merged commit f3f5d92 into master May 4, 2023
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 4, 2023
@sadpandajoe
Copy link
Member

🏷️ preset:2023.17

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chart-ds-constraint-again branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants