fix: update migration chart_ds_constraint to have seperate batch op (#…

…23942)
apache · May 4, 2023 · f3f5d92 · f3f5d92
1 parent b7689fb
commit f3f5d92
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py b/superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py
@@ -84,7 +84,6 @@ def upgrade_slc(slc: Slice) -> None:
 def upgrade():
     bind = op.get_bind()
     session = db.Session(bind=bind)
-
     with op.batch_alter_table("slices") as batch_op:
         for slc in session.query(Slice).filter(Slice.datasource_type != "table").all():
             if slc.datasource_type == "query":
@@ -97,6 +96,10 @@ def upgrade():
                     slc.datasource_type,
                 )
 
+    # need commit the updated values for Slice.datasource_type before creating constraint
+    session.commit()
+
+    with op.batch_alter_table("slices") as batch_op:
         batch_op.create_check_constraint(
             "ck_chart_datasource", "datasource_type in ('table')"
         )