Skip to content

[WIP][Spark-54182] avoid intermedia dataframe creation in non-arrow codepath of df.toPandas #52897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −11
Open

[WIP][Spark-54182] avoid intermedia dataframe creation in non-arrow codepath of df.toPandas #52897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cadc77d
refactor: remove intermedia data frame
Yicong-Huang Nov 5, 2025
e8a2276
fix: format
Yicong-Huang Nov 5, 2025
7358e95
fix: empty df code path
Yicong-Huang Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions python/pyspark/sql/pandas/conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,22 @@ def toPandas(self) -> "PandasDataFrameLike":

# Below is toPandas without Arrow optimization.
rows = self.collect()
if len(rows) > 0:
pdf = pd.DataFrame.from_records(
rows, index=range(len(rows)), columns=self.columns # type: ignore[arg-type]
)
else:
pdf = pd.DataFrame(columns=self.columns)

if len(pdf.columns) > 0:
if len(self.columns) > 0:
timezone = jconf.sessionLocalTimeZone()
struct_in_pandas = jconf.pandasStructHandlingMode()

return pd.concat(
# Avoid intermediate pandas DataFrame creation by directly converting columns
if len(rows) > 0:
# Extract columns from rows
columns_data = list(zip(*rows))
series_list = [pd.Series(col_data) for col_data in columns_data]
else:
# Empty rows - create empty DataFrame and extract empty Series
pdf_temp = pd.DataFrame(columns=self.columns)
series_list = [pser for _, pser in pdf_temp.items()]

pdf = pd.concat(
[
_create_converter_to_pandas(
field.dataType,
Expand All @@ -208,13 +212,15 @@ def toPandas(self) -> "PandasDataFrameLike":
),
error_on_duplicated_field_names=False,
timestamp_utc_localized=False,
)(pser)
for (_, pser), field in zip(pdf.items(), self.schema.fields)
)(series)
for series, field in zip(series_list, self.schema.fields)
],
axis="columns",
)
else:
pdf.columns = self.columns
return pdf
else:
return pd.DataFrame(columns=[], index=range(len(rows)))

def toArrow(self) -> "pa.Table":
from pyspark.sql.dataframe import DataFrame
Expand Down