Skip to content

Conversation

@jerrypeng
Copy link
Contributor

What changes were proposed in this pull request?

Add some additional end to end tests for RTM

Why are the changes needed?

To have better test coverage for RTM functionality

Does this PR introduce any user-facing change?

no

How was this patch tested?

N/A. Only tests are added

Was this patch authored or co-authored using generative AI tooling?

no

@dongjoon-hyun
Copy link
Member

Thank you, @jerrypeng .

import org.apache.spark.sql.test.TestSparkSession
import org.apache.spark.sql.types.{IntegerType, StringType, StructType}

class StreamRealTimeModeE2ESuite extends StreamRealTimeModeE2ESuiteBase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the CI failure?

2025-11-04T07:01:24.2425213Z �[0m[�[0m�[31merror�[0m] �[0m�[0mFailed tests:�[0m
2025-11-04T07:01:24.2426468Z �[0m[�[0m�[31merror�[0m] �[0m�[0m	org.apache.spark.sql.streaming.StreamRealTimeModeSuite�[0m

override protected def createSparkSession =
new TestSparkSession(
new SparkContext(
"local[15]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use more smaller values like other tests? According to the commit logs, RTM test suites seem to use this kind of high values. I'm wondering if this is required for some reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants