-
Couldn't load subscription status.
- Fork 28
chore: Upgrade Datafusion (v50) and Arrow (v56) dependencies #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It might be good to go straight to apache/datafusion#17888 (since we'll need it for Geometry/Geography support in Parquet), although if you need this version as an intermediary that's ok too! |
I will need the dafafusion v50.2.0 to unblock merging upstream in a dependency project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades DataFusion from version 49 to version 50.2.0 and Arrow from version 55.1.0 to version 56.0.0. The changes address API modifications and deprecations introduced in these newer versions.
Key Changes
- Updated dependency versions for DataFusion (49.0.0 → 50.2.0) and Arrow (55.1.0 → 56.0.0) in Cargo.toml
- Added
config_optionsparameter toScalarFunctionArgsthroughout the codebase to comply with new API requirements - Implemented
PartialEq,Eq, andHashtraits for UDF wrapper types to satisfy new DataFusion requirements - Updated metadata fetching API calls to use new
DFParquetMetadatabuilder pattern
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated Arrow and DataFusion version dependencies; replaced DataFusion git patch with arrow-adbc git dependency |
| rust/sedona/src/show.rs | Added ConfigOptions import and parameter; commented out deprecated truncation indicator |
| rust/sedona/src/random_geometry_provider.rs | Added explicit type annotation for projection expressions |
| rust/sedona/src/ffi.rs | Implemented PartialEq/Eq/Hash for exported types; added config_options parameter |
| rust/sedona/src/context.rs | Updated test expectation for EmptyRelation display format |
| rust/sedona-testing/src/testers.rs | Added config_options parameter to ScalarFunctionArgs |
| rust/sedona-spatial-join/src/optimizer.rs | Extracted config options to variable; added config_options parameter |
| rust/sedona-schema/src/schema.rs | Made trait method calls explicit to resolve type inference |
| rust/sedona-geoparquet/src/writer.rs | Added ConfigOptions import and parameter |
| rust/sedona-geoparquet/src/format.rs | Migrated to DFParquetMetadata builder pattern |
| rust/sedona-geoparquet/src/file_opener.rs | Migrated to DFParquetMetadata builder pattern |
| rust/sedona-geoparquet/Cargo.toml | Added datafusion-datasource-parquet dependency |
| rust/sedona-functions/src/st_setsrid.rs | Added ConfigOptions import and parameter in tests |
| rust/sedona-expr/src/spatial_filter.rs | Added ConfigOptions parameter to multiple test cases |
| rust/sedona-expr/src/scalar_udf.rs | Implemented PartialEq/Eq/Hash for SedonaScalarUDF |
| rust/sedona-expr/src/aggregate_udf.rs | Implemented PartialEq/Eq/Hash for SedonaAggregateUDF |
| python/sedonadb/tests/test_dataframe.py | Updated test expectations for EmptyRelation display |
| python/sedonadb/python/sedonadb/dataframe.py | Updated documentation example for EmptyRelation display |
| c/sedona-proj/src/st_transform.rs | Added ConfigOptions import and parameter in tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
A few things that should be handled here but also feel free to open follow-up tickets for non-trivial updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.