Skip to content

Conversation

@zhangfengcdt
Copy link
Member

No description provided.

@zhangfengcdt zhangfengcdt changed the title Chore: Upgrade Datafusion (v50) and Arrow (v56) dependencies chore: Upgrade Datafusion (v50) and Arrow (v56) dependencies Oct 23, 2025
@paleolimbot
Copy link
Member

It might be good to go straight to apache/datafusion#17888 (since we'll need it for Geometry/Geography support in Parquet), although if you need this version as an intermediary that's ok too!

@zhangfengcdt
Copy link
Member Author

zhangfengcdt commented Oct 23, 2025

It might be good to go straight to apache/datafusion#17888 (since we'll need it for Geometry/Geography support in Parquet), although if you need this version as an intermediary that's ok too!

I will need the dafafusion v50.2.0 to unblock merging upstream in a dependency project.

@zhangfengcdt zhangfengcdt marked this pull request as ready for review October 27, 2025 16:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades DataFusion from version 49 to version 50.2.0 and Arrow from version 55.1.0 to version 56.0.0. The changes address API modifications and deprecations introduced in these newer versions.

Key Changes

  • Updated dependency versions for DataFusion (49.0.0 → 50.2.0) and Arrow (55.1.0 → 56.0.0) in Cargo.toml
  • Added config_options parameter to ScalarFunctionArgs throughout the codebase to comply with new API requirements
  • Implemented PartialEq, Eq, and Hash traits for UDF wrapper types to satisfy new DataFusion requirements
  • Updated metadata fetching API calls to use new DFParquetMetadata builder pattern

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Updated Arrow and DataFusion version dependencies; replaced DataFusion git patch with arrow-adbc git dependency
rust/sedona/src/show.rs Added ConfigOptions import and parameter; commented out deprecated truncation indicator
rust/sedona/src/random_geometry_provider.rs Added explicit type annotation for projection expressions
rust/sedona/src/ffi.rs Implemented PartialEq/Eq/Hash for exported types; added config_options parameter
rust/sedona/src/context.rs Updated test expectation for EmptyRelation display format
rust/sedona-testing/src/testers.rs Added config_options parameter to ScalarFunctionArgs
rust/sedona-spatial-join/src/optimizer.rs Extracted config options to variable; added config_options parameter
rust/sedona-schema/src/schema.rs Made trait method calls explicit to resolve type inference
rust/sedona-geoparquet/src/writer.rs Added ConfigOptions import and parameter
rust/sedona-geoparquet/src/format.rs Migrated to DFParquetMetadata builder pattern
rust/sedona-geoparquet/src/file_opener.rs Migrated to DFParquetMetadata builder pattern
rust/sedona-geoparquet/Cargo.toml Added datafusion-datasource-parquet dependency
rust/sedona-functions/src/st_setsrid.rs Added ConfigOptions import and parameter in tests
rust/sedona-expr/src/spatial_filter.rs Added ConfigOptions parameter to multiple test cases
rust/sedona-expr/src/scalar_udf.rs Implemented PartialEq/Eq/Hash for SedonaScalarUDF
rust/sedona-expr/src/aggregate_udf.rs Implemented PartialEq/Eq/Hash for SedonaAggregateUDF
python/sedonadb/tests/test_dataframe.py Updated test expectations for EmptyRelation display
python/sedonadb/python/sedonadb/dataframe.py Updated documentation example for EmptyRelation display
c/sedona-proj/src/st_transform.rs Added ConfigOptions import and parameter in tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

A few things that should be handled here but also feel free to open follow-up tickets for non-trivial updates.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zhangfengcdt zhangfengcdt merged commit c67484c into apache:main Oct 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants