Skip to content

Avoid unnecessary ByteString concat for strict HTTP/2 entities #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
He-Pin wants to merge 1 commit into from
Closed

Avoid unnecessary ByteString concat for strict HTTP/2 entities #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/Http2StreamHandling.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,10 @@ private[http2] trait Http2StreamHandling extends GraphStageLogic with LogHelper
extraInitialWindow: Int) extends ReceivingData {

override protected def onDataFrame(dataFrame: DataFrame): StreamState = {
val newData = collectedData ++ dataFrame.payload
val newData =
if (collectedData.isEmpty) dataFrame.payload
else if (dataFrame.payload.isEmpty) collectedData
else collectedData ++ dataFrame.payload

if (dataFrame.endStream) {
totalBufferedData -= newData.length
Expand Down