Avoid unnecessary ByteString concat for strict HTTP/2 entities#1021
Closed
He-Pin wants to merge 1 commit into
Closed
Avoid unnecessary ByteString concat for strict HTTP/2 entities#1021He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Member
|
ByteString ++ already checks if either the left or right bytestring is empty and then does not return a new ByteStrings instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTP/2 DATA aggregation for small strict request entities may concatenate an empty
ByteStringwith the incoming payload. That adds unnecessary work and allocation on unary/small-request gRPC-like paths without changing stream semantics.Modification:
collectedData ++ payloadwhen either side is emptyResult:
The first DATA frame on the strict collection path now reuses the existing payload reference instead of allocating a concatenated
ByteString. Non-empty aggregation behavior is unchanged.Verification:
sbt "http-core / scalafmtCheck" "http2-tests / Test / testOnly org.apache.pekko.http.impl.engine.http2.Http2ServerSpec -- -z collect"Risk / Boundary:
ByteStringboundary