Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add link to LogicalTypes.md #38

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

MINOR: Add link to LogicalTypes.md #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/File Format/Types/logicaltypes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ of primitive types to a minimum and reuses parquet's efficient encodings. For
example, strings are stored as byte arrays (binary) with a UTF8 annotation.
These annotations define how to further decode and interpret the data.
Annotations are stored as `LogicalType` fields in the file metadata and are
documented in LogicalTypes.md.
documented in [LogicalTypes.md](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by purpose. Or at least we should link to a release version: https://github.com/apache/parquet-format/blob/apache-parquet-format-2.10.0/LogicalTypes.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way we can do this in a way that will always link to the right version of the docs? Happy to do the update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had a similar discussion since it is painful to update the site for every release: https://lists.apache.org/thread/5qrcz8ps83hnd079dtzd1q6xm31zjbvh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the link as is. I don't think the link will break any time soon :)