MINOR: Add link to LogicalTypes.md
#38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing broken link
wgtmac
reviewed
Jan 20, 2024
| @@ -10,4 +10,4 @@ of primitive types to a minimum and reuses parquet's efficient encodings. For | |||
| example, strings are stored as byte arrays (binary) with a UTF8 annotation. | |||
| These annotations define how to further decode and interpret the data. | |||
| Annotations are stored as `LogicalType` fields in the file metadata and are | |||
| documented in LogicalTypes.md. | |||
| documented in [LogicalTypes.md](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md) | |||
There was a problem hiding this comment.
This is by purpose. Or at least we should link to a release version: https://github.com/apache/parquet-format/blob/apache-parquet-format-2.10.0/LogicalTypes.md
There was a problem hiding this comment.
is there a way we can do this in a way that will always link to the right version of the docs? Happy to do the update
There was a problem hiding this comment.
We've had a similar discussion since it is painful to update the site for every release: https://lists.apache.org/thread/5qrcz8ps83hnd079dtzd1q6xm31zjbvh
There was a problem hiding this comment.
I would add the link as is. I don't think the link will break any time soon :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing broken link