net/tcp:Use a temporary variable to store dev to prevent conn from being released after tcp_conn_list_unlock. #18263
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing released after tcp_conn_list_unlock. Change-Id: I6eb1e873c76666c9dcbaab33c3fe7719751529f8 Signed-off-by: yangjianqing <[email protected]>
github-actions
bot
added
Area: Networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After
tcp_conn_list_unlock,connmight be released, soconn->timeout = trueis moved to the lock protection scope. At the same time, a temporary variable is used to storedevto preventconnfrom being released.Impact
Severity: High
Type: Race condition / Use-After-Free
Affected scenario: High-concurrency TCP connection timeout handling, especially on multi-core systems where the timing window between unlock and access can be exploited by other CPU cores
Testing
none