nucleo-h743zi/elf: modify the romfs img file path #17397
Conversation
Since the directory structure of the examples/elf project has been reorganized, the corresponding ROMFS_IMAGEFILE path also needs to be adjusted. Signed-off-by: guoshichao <[email protected]>
extinguish
requested review from
Donny9,
GUIDINGLI,
btashton and
xiaoxiang781216
as code owners
github-actions
bot
added
Board: arm
Size: XS
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
I don't think it's a testing concern that this would break ostest. Can you just include some test logs from the H743ZI board that you can still access the ROMFS image after boot?
|
I guess the CI is failing because of the dependency on the nuttx-apps PR? |
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @extinguish, please fix the CI build problem, looks like similar problem in apache/nuttx-apps#3224 ?
====================================================================================
Configuration/Tool: nucleo-h743zi/elf,CONFIG_ARM_TOOLCHAIN_CLANG
2025-11-28 13:05:33
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_CLANG
Building NuttX...
Error: <inline asm>:5:12: error: Could not find incbin file '../../apps/examples/elf/main/elf_romfs.img'
5 | .incbin "../../apps/examples/elf/main/elf_romfs.img"
| ^
1 error generated.
make[2]: *** [/github/workspace/sources/nuttx/boards/Board.mk:83: stm32_romfs_initialize.o] Error 1
make[2]: Target 'libboard.a' not remade because of errors.
make[1]: *** [Makefile:187: board/libboard.a] Error 2
make[1]: Target 'nuttx' not remade because of errors.
make: *** [tools/Unix.mk:552: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
[1/1] Normalize nucleo-h743zi/elf
HEAD detached at pull/17397/merge
Untracked files:
(use "git add <file>..." to include in what will be committed)
boards/arm/stm32h7/nucleo-h743zi/scripts/flash.ld.tmp
nothing added to commit but untracked files present (use "git add" to track)
Nope, part in nuttx-apps fails too, something needs a fix, or there is a circular dependency that should not be here :-) |
| CONFIG_STM32H7_USART3=y | ||
| CONFIG_STM32_ROMFS=y | ||
| CONFIG_STM32_ROMFS_IMAGEFILE="../../apps/examples/elf/tests/romfs.img" | ||
| CONFIG_STM32_ROMFS_IMAGEFILE="../../apps/examples/elf/main/elf_romfs.img" |
There was a problem hiding this comment.
Question: if the user is using "nuttx-apps" instead of "apps" this link will not work. I think we need to find a way to fix it. Not a blocking for this PR, but I suggest we discuss about possible solutions to it.
There was a problem hiding this comment.
good catch @acassis ! this path must not be hardcoded! :D
6 participants
Summary
Since the directory structure of the examples/elf project has been reorganized, the corresponding ROMFS_IMAGEFILE path also needs to be adjusted.
this pull request is depends on: apache/nuttx-apps#3224
Impact
has no impact on non-elf operations
Testing
has passed the ostest