Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weact stm32h743vit6 usbconsole fix #13667

Closed

Conversation

TOMASHEVSKIYIVAN
Copy link
Contributor

@TOMASHEVSKIYIVAN TOMASHEVSKIYIVAN commented Sep 27, 2024

fix previous problemc

added defconfig for weact-stm32h743:nshusb

Summary

added full support of usb console

Impact

new debug experience

Testing

@github-actions github-actions bot added Area: Board support Board support issues Size: M The size of the change in this PR is medium labels Sep 27, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 27, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:

    • Why is the change necessary? What problem does it fix?
    • What functional part of the code is being changed? Be specific (e.g., USB driver, networking stack, build system).
    • How does the change work? Provide technical details about the implementation.
    • Related Issues/PRs: Link any relevant issues or pull requests.
  • Impact:

    • Most of the impact sections are left blank. You must address each point, even if the answer is "NO" (provide a brief explanation if necessary).
  • Testing:

    • Insufficient Detail: "fix previous problemc" and "added defconfig" are not descriptive enough.
    • Missing Logs: You need to provide actual testing logs from before and after the change to demonstrate the issue and the fix.

Recommendations:

  1. Expand the Summary: Clearly articulate the problem, solution, and technical details of your change.
  2. Complete the Impact Section: Thoroughly address each impact point, even if the answer is "NO."
  3. Provide Detailed Testing Information: Include:
    • Specific build host and target details.
    • Clear and complete testing logs from before and after the change.
    • Steps to reproduce the issue (if applicable).

Remember: A well-written PR makes it easier for maintainers to understand and review your changes, increasing the likelihood of your contribution being accepted.

@TOMASHEVSKIYIVAN TOMASHEVSKIYIVAN deleted the TOMASHEVSKIYIVAN/master branch September 27, 2024 09:54
@TOMASHEVSKIYIVAN TOMASHEVSKIYIVAN restored the TOMASHEVSKIYIVAN/master branch September 27, 2024 09:54
commit 2e90060
Merge: 711f622 0d56dac
Author: Tomashevskiy <[email protected]>
Date:   Fri Sep 27 19:13:45 2024 +0300

    Merge branch 'master' of https://github.com/TOMASHEVSKIYIVAN/nuttx

commit 711f622
Author: Tomashevskiy <[email protected]>
Date:   Wed Sep 25 22:55:01 2024 +0300

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

    added defconfig for weact-stm32h743:nshusb

    board.h
    Wrong column position or missing blank line before comment: FIX

    board.h
    Wrong column position or missing blank line before comment: FIX

commit 0d56dac
Author: Tomashevskiy <[email protected]>
Date:   Wed Sep 25 22:55:01 2024 +0300

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

    added defconfig for weact-stm32h743:nshusb

    board.h
    Wrong column position or missing blank line before comment: FIX

    board.h
    Wrong column position or missing blank line before comment: FIX

commit 6b8f57e
Author: Tomashevskiy <[email protected]>
Date:   Wed Sep 25 22:55:01 2024 +0300

    weact stm32h743vit6 usbconsole fix

    fix previous problemc

weact stm32h743vit6 usbconsole fix

fix previous problemc

weact stm32h743vit6 usbconsole fix

fix previous problemc

added defconfig for weact-stm32h743:nshusb

board.h
Wrong column position or missing blank line before comment: FIX

board.h
Wrong column position or missing blank line before comment: FIX
fix previous problemc

added defconfig for weact-stm32h743:nshusb

board.h
Wrong column position or missing blank line before comment: FIX

hopefully last commit
@github-actions github-actions bot added Size: XS The size of the change in this PR is very small and removed Size: M The size of the change in this PR is medium labels Sep 28, 2024
@TOMASHEVSKIYIVAN TOMASHEVSKIYIVAN closed this by deleting the head repository Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Board support Board support issues Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants