-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensor:Update sensor type #13639
sensor:Update sensor type #13639
Conversation
[Experimental Bot, please feedback here] The PR summary is somewhat informative but could be more specific. Mentioning specific sensor types or groups and the reasoning behind aligning with AOSP would make it stronger. However, the major issue is the lack of detail in the Impact and Testing sections. Here's a breakdown of what's missing and how to improve: Impact:
Testing:
In short, the PR currently doesn't meet the NuttX requirements due to the lack of detail in the Impact and Testing sections. Providing specific and comprehensive information in these areas is crucial for reviewers to understand and approve the changes. |
…droid type. https://cs.android.com/android/_/android/platform/hardware/libhardware/+/0e67aa0caee9500b61b9c1c8b6e5cab18301364c:include_all/hardware/sensors.h Nuttx <-------------------------------> Android int32_t <-- version --> int float <-- power --> float float <-- max_range --> float float <-- resolution --> float int32_t <-- min_delay --> int32_t int32_t <-- max_delay --> int32/64_t uint32_t <-- fifo_reserved_event_count --> uint32_t uint32_t <-- fifo_max_event_count --> uint32_t char[] <-- name --> char* char[] <-- vendor --> char* Signed-off-by: likun17 <[email protected]>
Signed-off-by: likun17 <[email protected]>
5223e9c
to
0fb44c3
Compare
@Otpvondoiats @xiaoxiang781216 why is this error:
|
look like the ci temp failure, let's restart ci. |
For details, see: https://developer.android.com/reference/android/hardware/SensorEvent#values Signed-off-by: likun17 <[email protected]>
0fb44c3
to
ac86358
Compare
Summary
Impact
n/a
Testing
OS and Version: Ubuntu 20.04.6 LTS x86_64
GCC Version: 13.1.0
SIM: ./tools/configure.sh sim:nsh
./nuttx