[KYUUBI #6920][FOLLOWUP] Spark SQL engine supports Spark 4.0#7061
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[KYUUBI #6920][FOLLOWUP] Spark SQL engine supports Spark 4.0#7061pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7061 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 696 697 +1
Lines 43032 43185 +153
Branches 5849 5851 +2
=======================================
- Misses 43032 43185 +153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfmcgrady
reviewed
May 15, 2025
| HiveTable(sparkSession, catalog.getTableMetadata(ident.asTableIdentifier), this) | ||
| } | ||
|
|
||
| // scalastyle:off |
Contributor
There was a problem hiding this comment.
why do we need to disable the style check for this method?
Member
Author
There was a problem hiding this comment.
because the arg list is too long
cfmcgrady
approved these changes
May 16, 2025
pan3793
added a commit
that referenced
this pull request
May 16, 2025
### Why are the changes needed? There were some breaking changes after we fixed compatibility for Spark 4.0.0 RC1 in #6920, but now Spark has reached 4.0.0 RC6, which has less chance to receive more breaking changes. ### How was this patch tested? Changes are extracted from #6928, which passed CI with Spark 4.0.0 RC6 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7061 from pan3793/6920-followup. Closes #6920 17a1bd9 [Cheng Pan] [KYUUBI #6920][FOLLOWUP] Spark SQL engine supports Spark 4.0 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit e366b09) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
Merged to master/1.10 |
pan3793
added a commit
that referenced
this pull request
May 20, 2025
There were some breaking changes after we fixed compatibility for Spark 4.0.0 RC1 in #6920, but now Spark has reached 4.0.0 RC6, which has less chance to receive more breaking changes. Changes are extracted from #6928, which passed CI with Spark 4.0.0 RC6 No. Closes #7061 from pan3793/6920-followup. Closes #6920 17a1bd9 [Cheng Pan] [KYUUBI #6920][FOLLOWUP] Spark SQL engine supports Spark 4.0 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There were some breaking changes after we fixed compatibility for Spark 4.0.0 RC1 in #6920, but now Spark has reached 4.0.0 RC6, which has less chance to receive more breaking changes.
How was this patch tested?
Changes are extracted from #6928, which passed CI with Spark 4.0.0 RC6
Was this patch authored or co-authored using generative AI tooling?
No.