[WIP] [AUTHZ] hive function usage authz plugin #5144
Draft
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| object RuleFunctionAuthorization { | ||
|
|
||
| private val functionPrivAndOpType = new ThreadLocal[PrivilegesAndOpType] |
There was a problem hiding this comment.
It might be risky to use ThreadLocal as the function privileges holder.
Is it possible to put them in logical plan's tag via setTagValue ?
There was a problem hiding this comment.
It might be risky to use
ThreadLocalas the function privileges holder. Is it possible to put them in logical plan's tag viasetTagValue?
As the LogicalPlan instances between Analyzer Stage and Optimizer Stage could be different, I don't think it is possible to use 'setTagValue' to track them.
Any other ideas?
bowenliang123
changed the title
|
Do we need to add a toggle parameter for this feature, and set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request