KAFKA-19322: Remove the DelayedOperation constructor that accepts an external lock #19798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
@Mirai1129 please fix the build by removing the usages of the removed constructor |
|
@chia7712 Thank you so much! Fixed! |
m1a2st
reviewed
May 24, 2025
FrankYang0529
approved these changes
May 24, 2025
m1a2st
approved these changes
May 25, 2025
|
@Mirai1129 please rebase the code to include #19759 |
# Conflicts: # server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java
|
Done! |
chia7712
reviewed
May 25, 2025
| public DelayedOperation(long delayMs, Optional<Lock> lockOpt) { | ||
| this(delayMs, lockOpt.orElse(new ReentrantLock())); | ||
| } | ||
| protected final Lock lock = new ReentrantLock(); |
There was a problem hiding this comment.
Could you please change the type from Lock to ReentrantLock? This class requires some features of ReentrantLock.
chia7712
reviewed
May 25, 2025
| @@ -977,7 +977,7 @@ class ReplicaManager(val config: KafkaConfig, | |||
| if (delayedProduceRequestRequired(requiredAcks, entriesPerPartition, initialAppendResults)) { | |||
| // create delayed produce operation | |||
| val produceMetadata = ProduceMetadata(requiredAcks, initialProduceStatus) | |||
| val delayedProduce = new DelayedProduce(timeoutMs, produceMetadata, this, responseCallback, delayedProduceLock) | |||
| val delayedProduce = new DelayedProduce(timeoutMs, produceMetadata, this, responseCallback) | |||
There was a problem hiding this comment.
Please remove delayedProduceLock from method signature too
|
Please cleanup |
chia7712
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the DelayedOperation constructor that accepts an external lock.
According to this PR.
Reviewers: Ken Huang [email protected], PoAn Yang
[email protected], TengYao Chi [email protected], Chia-Ping Tsai
[email protected]