KAFKA-19144 Move DelayedProduce to server module #19793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny94
force-pushed
the
kafka-19144_move_delayed_produce_to_server_module
branch
from
03e76dc to
9f2951e
Compare
Comment on lines
1011
to
1012
| val produceResponseStatus = initialProduceStatus.map { case (k, status) => k -> status.responseStatus } | ||
| responseCallback(produceResponseStatus) | ||
| responseCallback(produceResponseStatus.asJava) |
There was a problem hiding this comment.
We use initialProduceStatus to build a Scala map and transfer to Java. Probably, we can build a Java map directly, so we can avoid asJava here.
val produceResponseStatus = new util.HashMap[TopicIdPartition, PartitionResponse]()
initialProduceStatus.foreach { case (k, status) => produceResponseStatus.put(k, status.responseStatus()) }
responseCallback(produceResponseStatus)| @@ -1006,7 +1026,7 @@ class ReplicaManager(val config: KafkaConfig, | |||
| LogAppendInfo.UNKNOWN_LOG_APPEND_INFO.logStartOffset | |||
| ) | |||
| } | |||
| responseCallback(responseStatus) | |||
| responseCallback(responseStatus.asJava) | |||
There was a problem hiding this comment.
ditto
val responseStatus = new util.HashMap[TopicIdPartition, PartitionResponse]()
entries.foreach { case (topicIdPartition, _) =>
responseStatus.put(topicIdPartition, new PartitionResponse(
Errors.INVALID_REQUIRED_ACKS,
LogAppendInfo.UNKNOWN_LOG_APPEND_INFO.firstOffset,
RecordBatch.NO_TIMESTAMP,
LogAppendInfo.UNKNOWN_LOG_APPEND_INFO.logStartOffset
))
}
responseCallback(responseStatus)
|
I will review this PR after #19798 gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
DelayedProduceto the server module. One notable change is that the type of theresponseCallbackparameter inReplicaManager#appendRecords()has been changed to a JavaMap. Other related type changes have been made accordingly.