-
Notifications
You must be signed in to change notification settings - Fork 14.4k
KAFKA-19300: AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationException #19779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…horizationException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rancho-7 Could you please add @Timeout
to testConsumeUnsubscribeWithoutGroupPermission
? With this fix, the elapsed time of the test should be shorter.
@@ -443,7 +443,7 @@ public void transitionToFatal() { | |||
log.error("Member {} with epoch {} transitioned to fatal state", memberId, memberEpoch); | |||
notifyEpochChange(Optional.empty()); | |||
|
|||
if (previousState == MemberState.UNSUBSCRIBED) { | |||
if (previousState == MemberState.UNSUBSCRIBED && maybeCompleteLeaveInProgress()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think StreamsMembershipManager
needs this change as well. cc @mjsax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Thanks for the suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice some different behavior between async and stream (https://github.com/apache/kafka/pull/18551/files#r2106243432). Maybe we can open a ticket to log it instead of changing it right now. This PR can fix the actual issue in Async consumer, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I have opened https://issues.apache.org/jira/browse/KAFKA-19333 to track this.
@Rancho-7 please check the failed test |
@@ -480,6 +480,7 @@ public void transitionToFatal() { | |||
if (previousState == MemberState.UNSUBSCRIBED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please consider modifying the unit test to keep the production code consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it.
jira: https://issues.apache.org/jira/browse/KAFKA-19300
I verified the behavior by rewriting the
GroupAuthorizerIntegrationTest
in Java in this PR:#19685 The state is now correct.
Reviewers: Chia-Ping Tsai [email protected]