KAFKA-19300: AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationException #19779
Conversation
…horizationException
github-actions
bot
added
triage
| @@ -443,7 +443,7 @@ public void transitionToFatal() { | |||
| log.error("Member {} with epoch {} transitioned to fatal state", memberId, memberEpoch); | |||
| notifyEpochChange(Optional.empty()); | |||
|
|
|||
| if (previousState == MemberState.UNSUBSCRIBED) { | |||
| if (previousState == MemberState.UNSUBSCRIBED && maybeCompleteLeaveInProgress()) { | |||
There was a problem hiding this comment.
I think StreamsMembershipManager needs this change as well. cc @mjsax
There was a problem hiding this comment.
Sure. Thanks for the suggestion!
There was a problem hiding this comment.
I notice some different behavior between async and stream (https://github.com/apache/kafka/pull/18551/files#r2106243432). Maybe we can open a ticket to log it instead of changing it right now. This PR can fix the actual issue in Async consumer, WDYT?
There was a problem hiding this comment.
Sounds good, I have opened https://issues.apache.org/jira/browse/KAFKA-19333 to track this.
github-actions
bot
added
core
|
@Rancho-7 please check the failed test |
| @@ -480,6 +480,7 @@ public void transitionToFatal() { | |||
| if (previousState == MemberState.UNSUBSCRIBED) { | |||
There was a problem hiding this comment.
Could you please consider modifying the unit test to keep the production code consistent?
…19968) this is a follow-up for #19685 The timeout issue in `AsyncConsumer#unsubscribe` was fixed by #19779. As a result, the test `GroupAuthorizerIntegrationTest#testConsumeUnsubscribeWithoutGroupPermission` should now retain its original behavior as expected prior to the issue. Reviewers: Chia-Ping Tsai <[email protected]>
jira: https://issues.apache.org/jira/browse/KAFKA-19300
I verified the behavior by rewriting the
GroupAuthorizerIntegrationTestin Java in this PR:#19685 The state is now correct.
Reviewers: Chia-Ping Tsai [email protected]