MINOR: Restore original behavior of GroupAuthorizerIntegrationTest #19968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rancho-7
changed the title
github-actions
bot
added
tests
|
@Rancho-7 could you please loop the test to ensure it is stable? |
chia7712
reviewed
Jun 17, 2025
| } | ||
|
|
||
| private void testConsumeUnsubscribeWithGroupPermission(ClusterInstance clusterInstance, GroupProtocol groupProtocol) throws InterruptedException, ExecutionException { | ||
| private void testConsumeUnsubscribeWithoutGroupPermission(ClusterInstance clusterInstance, GroupProtocol groupProtocol) throws InterruptedException, ExecutionException { |
There was a problem hiding this comment.
Perhaps we can keep both cases?
There was a problem hiding this comment.
Sounds good,I will keep both.
|
@Rancho-7 could you please try to eliminate the duplicate code? |
Updated. |
chia7712
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-up for #19685
The timeout issue in
AsyncConsumer#unsubscribewas fixed by#19779. As a result, the test
GroupAuthorizerIntegrationTest#testConsumeUnsubscribeWithoutGroupPermissionshould now retain its original behavior as expected prior to the issue.
Reviewers: Chia-Ping Tsai [email protected]