[Pipe] Fix tablet type conversion for failed columns - #18595
Merged
jt2594838 merged 1 commit intoSep 8, 2026
Merged
Conversation
jt2594838
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
A partial insert can leave a failed tablet measurement without a data type or value column. Pipe and Load type-conversion retries restore that failed measurement before schema validation, but their conversion overrides indexed the tablet arrays unconditionally. This could throw
NullPointerExceptionorArrayIndexOutOfBoundsExceptioninstead of preserving the partial-insert result.This is a follow-up to #17879, which made missing and null tablet columns valid partial-insert state across the write path.
Changes
Tests
mvn spotless:apply -pl iotdb-core/datanodeOK (3 tests)The regular single-module Maven test lifecycle was also attempted, but the local incremental build failed before test execution on unrelated generated fill/aggregation sources with missing symbols.
This PR has:
Key changed/added classes
PipeConvertedInsertTabletStatementLoadConvertedInsertTabletStatementPipeConvertedInsertTabletStatementTest