Skip to content

[Backport dev/1.3] [Pipe] Fix tablet type conversion for failed columns - #18607

Merged
jt2594838 merged 1 commit into
apache:dev/1.3from
Caideyipi:cp-18595-dev-1.3
Sep 9, 2026
Merged

[Backport dev/1.3] [Pipe] Fix tablet type conversion for failed columns#18607
jt2594838 merged 1 commit into
apache:dev/1.3from
Caideyipi:cp-18595-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Backports #18595 (31e7534811217440172d3b2edd27170ef8328c19) to dev/1.3.

Pipe and Load conversion retries can restore failed measurements whose source type or value column is missing. Validate tablet column state before conversion so those measurements remain failed while valid columns still convert successfully.

The production changes apply unchanged. The regression tests use the 1.3 public validateMeasurementSchema entry point and TsFile API, and construct partial-insert failures through markFailedMeasurement.

Validation

  • mvn spotless:apply -pl iotdb-core/datanode: passed.
  • mvn test -pl iotdb-core/datanode -am -Dtest=PipeConvertedInsertTabletStatementTest -Dsurefire.failIfNoSpecifiedTests=false: passed, all 26 reactor modules successful and all 3 regression tests passing.
  • Ran the same tests against the pre-backport converter classes: all 3 fail, reproducing out-of-bounds access in Pipe/Load and an incorrectly retained null-typed measurement.

This PR has:

  • been self-reviewed.
  • added Javadocs for the non-trivial validation method.
  • added unit tests covering Pipe and Load conversion of failed columns.

Key changed/added classes
  • PipeConvertedInsertTabletStatement
  • LoadConvertedInsertTabletStatement
  • PipeConvertedInsertTabletStatementTest

@jt2594838
jt2594838 merged commit 443ba32 into apache:dev/1.3 Sep 9, 2026
16 checks passed
@jt2594838
jt2594838 deleted the cp-18595-dev-1.3 branch September 10, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants