[HUDI-8784] Validate auto key gen for SQL #12520
Merged
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
validate_auto_key_gen_works
branch
from
a55cfba to
8662147
Compare
github-actions
bot
added
size:S
danny0405
reviewed
Dec 19, 2024
| @Test | ||
| def testAutoKeyGen(): Unit = { | ||
| // No record key is set, which should trigger auto key gen. | ||
| // MOR table is used to generate log files. |
There was a problem hiding this comment.
cow table is the default table type, and the default operation type is upsert.
There was a problem hiding this comment.
I have set it to MOR table, since it is more complex.
There was a problem hiding this comment.
@danny0405 , do you mean I should use COW?
There was a problem hiding this comment.
we can just test both table types.
linliu-code
commented
Dec 19, 2024
| val expectedDf = spark.createDataFrame(expected).toDF(columns: _*) | ||
| val expectedMinusActual = expectedDf.except(actualDf) | ||
| val actualMinusExpected = actualDf.except(expectedDf) | ||
| expectedMinusActual.show(false) |
There was a problem hiding this comment.
Will remove since this is for debug.
linliu-code
force-pushed
the
validate_auto_key_gen_works
branch
from
8662147 to
0e36f6f
Compare
linliu-code
force-pushed
the
validate_auto_key_gen_works
branch
from
0e36f6f to
798bd35
Compare
danny0405
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
To confirm if the auto key gen works well for Spark SQL.
Impact
Better reliability.
Risk level (write none, low medium or high below)
Low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist