Skip to content

[fix][ci] build fail on mac os #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luoyuxia merged 4 commits into from
Nov 25, 2025
Merged

[fix][ci] build fail on mac os #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b066a04
fix ci build fail use pinned python versions
binary-signal Nov 25, 2025
9e55885
Delete .github/.DS_Store
binary-signal Nov 25, 2025
2dac17a
Simplify Python version declaration in CI config
binary-signal Nov 25, 2025
a473f05
Fix comparison operator for macOS in CI config
binary-signal Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .github/.DS_Store
View file
Open in desktop
Copy link
Contributor

@luoyuxia luoyuxia Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. How can I miss it.

Binary file not shown.
55 changes: 44 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,34 @@ jobs:
os:
- ubuntu-latest
- macos-latest
python: ["3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}

- name: Install protoc
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
if [ "$RUNNER_OS" = "Linux" ]; then
sudo apt-get update && sudo apt-get install -y protobuf-compiler
elif [ "$RUNNER_OS" == "macOS" ]; then
elif [ "$RUNNER_OS" = "macOS" ]; then
brew install protobuf
fi

- name: Rust Cache
uses: actions/cache@v4
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: build-${{ runner.os }}-${{ matrix.python }}-${{ hashFiles('**/Cargo.lock') }}

- name: Build
run: cargo build
run: cargo build --workspace --all-targets

test:
runs-on: ${{ matrix.os }}
Expand All @@ -73,26 +90,42 @@ jobs:
os:
- ubuntu-latest
- macos-latest
python: ["3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}

- name: Install protoc
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
if [ "$RUNNER_OS" = "Linux" ]; then
sudo apt-get update && sudo apt-get install -y protobuf-compiler
elif [ "$RUNNER_OS" == "macOS" ]; then
elif [ "$RUNNER_OS" = "macOS" ]; then
brew install protobuf
fi

- name: Rust Cache
uses: actions/cache@v4
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: test-${{ runner.os }}-${{ matrix.python }}-${{ hashFiles('**/Cargo.lock') }}

- name: Unit Test
run: cargo test --all-targets --workspace
env:
RUST_LOG: DEBUG
RUST_BACKTRACE: full
- name: Integration Test
# only run IT in linux since no docker in macos by default

- name: Integration Test (Linux only)
if: runner.os == 'Linux'
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
RUST_TEST_THREADS=1 cargo test --features integration_tests --all-targets --workspace -- --nocapture
fi
RUST_TEST_THREADS=1 cargo test --features integration_tests --all-targets --workspace -- --nocapture
env:
RUST_LOG: DEBUG
RUST_BACKTRACE: full
RUST_BACKTRACE: full
Loading