Skip to content

Conversation

@binary-signal
Copy link
Contributor

CI jobs for #53 fails, This PR fixes the issue, specifically when running the CI on macOS.

It also improves the CI pipeline by defining a Python version matrix: 3.11, 3.12, 3.13. Python 3.14 support will be added later, so the current “latest usable” version is assumed to be 3.13, giving us a 3-version range.

A caching step for the Rust build was added as well, allowing to reuse build artifacts in downstream actions speeding up the CI.

Additionally, a portability fix was made in the Bash script, changing:

if [ "$RUNNER_OS" == "Linux" ]; then

to the POSIX-compatible:

if [ "$RUNNER_OS" = "Linux" ]; then

@binary-signal
Copy link
Contributor Author

@luoyuxia when you time have a look please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. How can I miss it.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@luoyuxia luoyuxia merged commit 6d9c89f into apache:main Nov 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants