Skip to content

[FLINK-40237][cep] Clean up expired NFA state in processing-time timers #28822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dream95 wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −0
Open

[FLINK-40237][cep] Clean up expired NFA state in processing-time timers #28822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/CepOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,11 @@ public void onProcessingTime(InternalTimer<KEY, VoidNamespace> timer) throws Exc

// STEP 4
updateNFA(nfa);

// In order to remove dangling partial matches.
if (nfa.getPartialMatches().size() == 1 && nfa.getCompletedMatches().isEmpty()) {
computationStates.clear();
}
}

private Stream<IN> sort(Collection<IN> elements) {
Expand Down Expand Up @@ -551,6 +556,12 @@ boolean hasNonEmptyPQ(KEY key) throws Exception {
return !elementQueueState.isEmpty();
}

@VisibleForTesting
boolean hasNonEmptyNFAState(KEY key) throws Exception {
setCurrentKey(key);
return computationStates.value() != null;
}

@VisibleForTesting
int getPQSize(KEY key) throws Exception {
setCurrentKey(key);
Expand Down
18 changes: 18 additions & 0 deletions flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,24 @@ public void testCEPOperatorCleanupProcessingTime() throws Exception {
}
}

@Test
public void testCEPOperatorClearsExpiredNFAStateInProcessingTime() throws Exception {
CepOperator<Event, Integer, Map<String, List<Event>>> operator = getKeyedCepOperator(true);

try (OneInputStreamOperatorTestHarness<Event, Map<String, List<Event>>> harness =
CepOperatorTestUtilities.getCepTestHarness(operator)) {
harness.open();
harness.setProcessingTime(1L);
harness.processElement(new StreamRecord<>(new Event(26, "start", 1.0)));

assertTrue(operator.hasNonEmptyNFAState(26));

harness.setProcessingTime(20L);

assertFalse(operator.hasNonEmptyNFAState(26));
}
}

@Test
public void testCEPOperatorSerializationWRocksDB() throws Exception {
String rocksDbPath = tempFolder.newFolder().getAbsolutePath();
Expand Down