[FLINK-40237][cep] Clean up expired NFA state in processing-time timers#28822
Open
Dream95 wants to merge 1 commit into
Open
[FLINK-40237][cep] Clean up expired NFA state in processing-time timers#28822Dream95 wants to merge 1 commit into
Dream95 wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
This is a follow-up to FLINK-32701.
CepOperatoralready cleans up dangling NFA state inonEventTime(), but the equivalent cleanup was missing fromonProcessingTime(). As a result, after patterns expire under processing time,computationStatescould retain only the initial partial match and never be cleared. This PR applies the same cleanup logic in the processing-time timer path.Brief change log
computationStatesinonProcessingTime()when only the initial partial match remains and there are no completed matches@VisibleForTestinghelperhasNonEmptyNFAState(KEY)to inspect per-key NFA statetestCEPOperatorClearsExpiredNFAStateInProcessingTimeto verify expired NFA state is removed after the processing-time timer firesVerifying this change
CEPOperatorTest#testCEPOperatorClearsExpiredNFAStateInProcessingTime, which processes a start event under processing time, asserts NFA state is present, advances processing time past the pattern timeout, and asserts NFA state is clearedDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?