Simplify MockClusterInvoker fail mock tests#16328
Open
gaoxiaolei-s59 wants to merge 1 commit into
Open
Conversation
gaoxiaolei-s59
force-pushed
the
codex/simplify-mock-cluster-invoker-test-v2
branch
from
101b61c to
9ca056f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16328 +/- ##
============================================
- Coverage 60.79% 60.79% -0.01%
+ Complexity 11777 11768 -9
============================================
Files 1953 1953
Lines 89208 89208
Branches 13458 13458
============================================
- Hits 54234 54231 -3
- Misses 29403 29407 +4
+ Partials 5571 5570 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Simplify
MockClusterInvokerTestby replacing broad try/catch assertions with focusedassertThrowschecks and extracting a shared helper for the fail-mock invoker setup.Supersedes #16327, which was recreated after repeated unrelated integration CI failures in the test image setup.
Brief changelog
getSomethingand an unconfigured method.Assertions.assertThrows.Verifying this change
./mvnw -pl dubbo-cluster -Dtest=MockClusterInvokerTest test./mvnw -pl dubbo-cluster test