Simplify MockClusterInvoker fail mock tests#16327
Closed
gaoxiaolei-s59 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16327 +/- ##
============================================
- Coverage 60.79% 60.47% -0.32%
+ Complexity 11777 10261 -1516
============================================
Files 1953 1953
Lines 89208 89208
Branches 13458 13458
============================================
- Hits 54234 53952 -282
- Misses 29403 29643 +240
- Partials 5571 5613 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Superseded by #16328 after recreating the pull request due to repeated unrelated integration CI failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR simplifies
MockClusterInvokerTest.testMockInvokerFromOverride_Invoke_Fock_WithOutDefaultby splitting the configured mock assertions and the unconfigured mock exception path into separate test cases.It also replaces the empty
try/catchplusAssertions.fail()pattern withAssertions.assertThrows, making the expectedRpcExceptionexplicit.Why
Keeping each test focused makes failures easier to diagnose and addresses the readability improvement requested in #10486.
Closes #10486.
Verification
./mvnw -pl dubbo-cluster -Dtest=MockClusterInvokerTest test./mvnw -pl dubbo-cluster test