[improvement](be) Remove redundant compile check wrappers#62300
Merged
zclllyybb merged 4 commits intoapache:masterfrom Apr 10, 2026
Merged
[improvement](be) Remove redundant compile check wrappers#62300zclllyybb merged 4 commits intoapache:masterfrom
zclllyybb merged 4 commits intoapache:masterfrom
Conversation
zclllyybb
requested review from
airborne12,
dataroaring and
gavinchou
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Issue Number: None
Related PR: None
Problem Summary: Remove obsolete compile_check_begin/end headers and all paired includes now that the compile option is enabled globally, while keeping minimal compile_check_avoid guards only around legacy code that still fails under global conversion checks.
None
- Test: build.sh --be
- Manual test
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Update the BE compile_check guidance after removing compile_check_begin/end and close the remaining unpaired compile_check_avoid wrapper in cpu_info.cpp.
### Release note
None
### Check List (For Author)
- Test: Manual test
- `./build.sh --be` previously linked `be/output/lib/doris_be`; the script then failed at missing `post-build.sh` in this worktree
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Restore cpu_info.cpp to a minimal compile_check_avoid scope so only the pre-namespace declarations remain exempt after removing compile_check_begin/end.
### Release note
None
### Check List (For Author)
- Test: Manual test
- `./build.sh --be` rebuilt `src/util/cpu_info.cpp`, linked `be/output/lib/doris_be`, and then failed at the existing missing `post-build.sh` step
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Rebase the compile_check cleanup onto upstream/master, remove newly introduced stale compile_check_begin/end references from upstream-touched BE files, and apply the required clang-format pass to the modified files.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Rebased onto `upstream/master` and ran `/mnt/disk6/common/ldb_toolchain_toucan/bin/clang-format` on all modified C/C++ files
- `./build.sh --be` produced `be/output/lib/doris_be` successfully after the rebase cleanup
- Behavior changed: No
- Does this need documentation: No
zclllyybb
force-pushed
the
agent/task-6db6fddf-remove-compile-check
branch
from
ccaf4f4 to
0ba9788
Compare
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
linrrzqqq
approved these changes
Apr 10, 2026
BiteTheDDDDt
approved these changes
Apr 10, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
added a commit
to dataroaring/incubator-doris
that referenced
this pull request
Apr 10, 2026
…appings_scanner PR apache#62077 added schema_role_mappings_scanner.cpp with compile_check_begin/end.h includes, but PR apache#62300 subsequently deleted those headers globally. This causes a compile failure on master: 'common/compile_check_begin.h' file not found. Generated by Claude Code
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove obsolete compile_check_begin/end headers and all paired includes now that the compile option is enabled globally, while keeping minimal compile_check_avoid guards only around legacy code that still fails under global conversion checks.