[fix](test) Rename tpch_sf10_unique_mor_p2 to sf100 and add missing .out files by dataroaring · Pull Request #62335 · apache/doris

dataroaring · 2026-04-10T08:22:29Z

Summary

Renamed tpch_sf10_unique_mor_p2 to tpch_sf100_unique_mor_p2 to use the SF100 dataset
Added 22 .out files (copied from tpch_sf100_p2) to fix Missing outputFile exceptions caused by the framework auto-discovering .sql files
Updated all DDL load files to use SF100 S3 data paths (tpch/sf100/ and tpch/sf100_split/ for lineitem)
Updated load.groovy row counts to match SF100 scale (e.g., lineitem: 600M, customer: 15M)

Test plan

Verify tpch_sf100_unique_mor_p2 SQL tests pass with the new .out files
Verify test_read_mor_as_dup groovy test passes with SF100 data
Verify test_mor_value_predicate_pushdown groovy test passes with SF100 data

🤖 Generated with Claude Code

…2 and use SF100 dataset The regression test was missing .out files for the auto-discovered SQL tests, causing Missing outputFile exceptions. Switch to SF100 dataset with known expected outputs from tpch_sf100_p2, and update S3 data paths and row counts accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Thearas · 2026-04-10T08:22:35Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Copilot

Pull request overview

This PR updates the tpch_sf100_unique_mor_p2 regression suite to consistently use the TPC-H SF100 dataset and prevents framework failures by adding the missing expected-result (.out) files for the suite’s auto-discovered SQL cases.

Changes:

Switch the suite’s load scripts and row-count expectations from SF10 scale to SF100 scale (including sf100_split for lineitem).
Add the full set of TPC-H q01–q22 .sql files and their corresponding .out files to satisfy the regression framework’s .sql auto-discovery.
Add two Groovy validations: MOR-as-DUP equivalence vs real DUP tables, and MOR value predicate pushdown correctness vs baseline.

Reviewed changes

Copilot reviewed 37 out of 79 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
regression-test/suites/tpch_sf100_unique_mor_p2/load.groovy	Update expected row counts to SF100 scale
regression-test/suites/tpch_sf100_unique_mor_p2/test_read_mor_as_dup.groovy	New test comparing MOR-as-DUP results with real DUP tables
regression-test/suites/tpch_sf100_unique_mor_p2/test_mor_value_predicate_pushdown.groovy	New test validating MOR value predicate pushdown vs baseline
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q01.sql	Add TPC-H query q01 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q02.sql	Add TPC-H query q02 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q03.sql	Add TPC-H query q03 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q04.sql	Add TPC-H query q04 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q05.sql	Add TPC-H query q05 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q06.sql	Add TPC-H query q06 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q07.sql	Add TPC-H query q07 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q08.sql	Add TPC-H query q08 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q09.sql	Add TPC-H query q09 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q10.sql	Add TPC-H query q10 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q11.sql	Add TPC-H query q11 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q12.sql	Add TPC-H query q12 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q13.sql	Add TPC-H query q13 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q14.sql	Add TPC-H query q14 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q15.sql	Add TPC-H query q15 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q16.sql	Add TPC-H query q16 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q17.sql	Add TPC-H query q17 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q18.sql	Add TPC-H query q18 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q19.sql	Add TPC-H query q19 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q20.sql	Add TPC-H query q20 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q21.sql	Add TPC-H query q21 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/sql/q22.sql	Add TPC-H query q22 for suite execution/auto-discovery
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/customer.sql	MOR unique-key table DDL for `customer`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/customer_load.sql	SF100 S3 load template for `customer`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/customer_dup.sql	DUP table DDL for `customer_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/customer_dup_load.sql	SF100 S3 load template for `customer_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/lineitem.sql	MOR unique-key table DDL for `lineitem`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/lineitem_load.sql	SF100 split S3 load template for `lineitem`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/lineitem_dup.sql	DUP table DDL for `lineitem_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/lineitem_dup_load.sql	SF100 split S3 load template for `lineitem_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/nation.sql	MOR unique-key table DDL for `nation`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/nation_load.sql	SF100 S3 load template for `nation`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/nation_dup.sql	DUP table DDL for `nation_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/nation_dup_load.sql	SF100 S3 load template for `nation_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/orders.sql	MOR unique-key table DDL for `orders`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/orders_load.sql	SF100 S3 load template for `orders`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/orders_dup.sql	DUP table DDL for `orders_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/orders_dup_load.sql	SF100 S3 load template for `orders_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/part.sql	MOR unique-key table DDL for `part`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/part_load.sql	SF100 S3 load template for `part`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/part_dup.sql	DUP table DDL for `part_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/part_dup_load.sql	SF100 S3 load template for `part_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/partsupp.sql	MOR unique-key table DDL for `partsupp`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/partsupp_load.sql	SF100 S3 load template for `partsupp`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/partsupp_dup.sql	DUP table DDL for `partsupp_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/partsupp_dup_load.sql	SF100 S3 load template for `partsupp_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/region.sql	MOR unique-key table DDL for `region`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/region_load.sql	SF100 S3 load template for `region`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/region_dup.sql	DUP table DDL for `region_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/region_dup_load.sql	SF100 S3 load template for `region_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/supplier.sql	MOR unique-key table DDL for `supplier`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/supplier_load.sql	SF100 S3 load template for `supplier`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/supplier_dup.sql	DUP table DDL for `supplier_dup`
regression-test/suites/tpch_sf100_unique_mor_p2/ddl/supplier_dup_load.sql	SF100 S3 load template for `supplier_dup`
regression-test/data/tpch_sf100_unique_mor_p2/sql/q01.out	Expected output for q01 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q02.out	Expected output for q02 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q03.out	Expected output for q03 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q04.out	Expected output for q04 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q05.out	Expected output for q05 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q06.out	Expected output for q06 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q07.out	Expected output for q07 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q08.out	Expected output for q08 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q09.out	Expected output for q09 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q10.out	Expected output for q10 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q11.out	Expected output for q11 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q12.out	Expected output for q12 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q13.out	Expected output for q13 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q14.out	Expected output for q14 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q15.out	Expected output for q15 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q16.out	Expected output for q16 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q17.out	Expected output for q17 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q18.out	Expected output for q18 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q19.out	Expected output for q19 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q20.out	Expected output for q20 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q21.out	Expected output for q21 (auto-discovered SQL case)
regression-test/data/tpch_sf100_unique_mor_p2/sql/q22.out	Expected output for q22 (auto-discovered SQL case)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dataroaring · 2026-04-10T08:35:59Z

run buildall

github-actions · 2026-04-10T08:49:39Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-04-10T08:49:41Z

PR approved by anyone and no changes requested.

dataroaring · 2026-04-10T09:42:13Z

The COMPILE failure on this PR is not caused by this PR's changes — it's a master-level issue.

Root cause: schema_role_mappings_scanner.cpp (added by #62077) includes common/compile_check_begin.h, which was deleted globally by #62300. This race condition breaks compilation on any PR building against current master.

Fix: #62343 removes the stale includes. Once that merges, re-triggering the build here should resolve the COMPILE failure.

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 10, 2026 08:22

Copilot started reviewing on behalf of dataroaring April 10, 2026 08:23 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

gavinchou approved these changes Apr 10, 2026

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2026

github-actions bot added the reviewed label Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](test) Rename tpch_sf10_unique_mor_p2 to sf100 and add missing .out files#62335

[fix](test) Rename tpch_sf10_unique_mor_p2 to sf100 and add missing .out files#62335
dataroaring wants to merge 1 commit intoapache:masterfrom
dataroaring:fix/tpch-sf100-unique-mor-regression-test

dataroaring commented Apr 10, 2026

Uh oh!

Thearas commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

dataroaring commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

dataroaring commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dataroaring commented Apr 10, 2026

Summary

Test plan

Uh oh!

Thearas commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

dataroaring commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

dataroaring commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants