Skip to content

Make test_display_pg_json pass regardless of build setup and dependencies #21502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamGS wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

Make test_display_pg_json pass regardless of build setup and dependencies #21502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd68f71
Make pass regardless of build setup and dependencies
AdamGS Apr 9, 2026
f7919b4
Add sqllogictest fix
AdamGS Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions datafusion/expr/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,6 @@ sqlparser = { workspace = true, optional = true }
ctor = { workspace = true }
env_logger = { workspace = true }
insta = { workspace = true }
# Makes sure `test_display_pg_json` behaves in a consistent way regardless of
# feature unification with dependencies
serde_json = { workspace = true, features = ["preserve_order"] }
3 changes: 3 additions & 0 deletions datafusion/sqllogictest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ substrait = ["datafusion-substrait"]
[dev-dependencies]
env_logger = { workspace = true }
regex = { workspace = true }
# Required to make sure tests for pg display behaves consistently
# regardless of feature unification with dependencies
serde_json = { workspace = true, features = ["preserve_order"] }
tokio = { workspace = true, features = ["rt-multi-thread"] }

[[test]]
Expand Down
Loading