Skip to content

Make test_display_pg_json pass regardless of build setup and dependencies#21502

Open
AdamGS wants to merge 2 commits intoapache:mainfrom
AdamGS:adamg/fix-pg-viz-test
Open

Make test_display_pg_json pass regardless of build setup and dependencies#21502
AdamGS wants to merge 2 commits intoapache:mainfrom
AdamGS:adamg/fix-pg-viz-test

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 9, 2026

Which issue does this PR close?

Rationale for this change

Running tests for datafusion-expr currently fails locally, but due to feature unification with the subtrait dependency it does pass in CI.

What changes are included in this PR?

Enables a feature for a dependency during tests.

Are these changes tested?

Ran tests for the crate directly.

Are there any user-facing changes?

None.

@AdamGS AdamGS changed the title Make pass regardless of build setup and dependencies Make test_display_pg_json pass regardless of build setup and dependencies Apr 9, 2026
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Apr 9, 2026
@AdamGS AdamGS force-pushed the adamg/fix-pg-viz-test branch from 5615771 to dd68f71 Compare April 9, 2026 10:17
@AdamGS
Copy link
Copy Markdown
Contributor Author

AdamGS commented Apr 9, 2026

Just realized that there's a SLT test that has the same question in explain.slt:642, it just runs explain format pgjson select * from values (1);. I'll add the same fix to the sqllogictest crate, I think its best to avoid enabling it globally because its a pretty popular crate and we don't want to impact downstream users.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant