Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brand Guidelines #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Dec 18, 2024

closes: #197


Change logs

Update Brand Guidelines.

Contributor's checklist

Here are some reminders before you submit your pull request:

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 18, 2024

Screenshots:

image

image

image

image

Copy link
Contributor

@edespino edespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Branding Guidlines cells with black and white images need to be updated to have their opposite color as the background. You can see in the images you provided, the white images are not visible because of the white background of the page. In my scenario, my page is black and the corresponding black images cannot be seen.

Screenshot 2024-12-18 at 10 22 23 PM

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 19, 2024

The Branding Guidlines cells with black and white images need to be updated to have their opposite color as the background. You can see in the images you provided, the white images are not visible because of the white background of the page. In my scenario, my page is black and the corresponding black images cannot be seen.

Screenshot 2024-12-18 at 10 22 23 PM

Good catch! Let me update the related cells' background and add some words as notes for easier viewing.

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 23, 2024

Add a light gray background for each logo file so they remain visible in both light and dark mode.

image

image

image

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 23, 2024

Hi @edespino please help review again when you're available, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the 'Brand Guidelines' to include the latest logos.
2 participants