-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48759: [Python] Remove Python 3.0.0 condition for pandas/issues/50127 #48760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillAyd @jorisvandenbossche any thoughts on this?
|
I am fine with it. Looks like a pretty old issue - I don't think its worth having to move the upper version bound here until this gets fixed |
|
Could this be merged by any change? 🙇 |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused, shouldn't we have seen this failing on the pandas-devel and pandas upstream job as those are 3.0.0 dev already? This specific test doesn't fail for those, I am wondering whether this could have been solved as part of a different issue.
|
Actually let me check. |
|
huh? tests passed but pandas-dev/pandas#50127 is still not resolved |
|
Alright. e2ac52d accidentally fixed this issue together. It does not trigger |
Rationale for this change
Tests
test_binary_column_nameandtest_roundtrip_with_bytes_unicodewere being skipped on pandas 2.0+ due to a pandas regression (pandas-dev/pandas#50127) that causedNotImplementedError: |S3when roundtripping DataFrames with bytes column names.This issue was already fixed in commit e2ac52d (GH-44171) by changing an
ifstatement toelifin_reconstruct_columns_from_metadata(). The fix prevents bytes-typed columns from falling through to thelevel.astype(dtype)call that triggered the pandas error.What changes are included in this PR?
Remove the skip conditions from two test cases.
Are these changes tested?
Yes all related tests pass.
Are there any user-facing changes?
No.