-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47106: [R] Update R package to use R 4.1+ native forward pipe syntax #47622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g r |
Revision: 6892a21 Submitted crossbow builds: ursacomputing/crossbow @ actions-0c305d6d3e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change feels pretty safe but I thought I'd kick off crossbow jobs just in case. Thanks for taking this on @thisisnic.
Looks like nightly libarrow for R isn't being built and we may need to add an override in the script for test-r-rhub-debian-gcc-release-custom-ccache to run correctly until |
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 48a2e88. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Don't need base pipe
What changes are included in this PR?
Update package to use native pipe
Are these changes tested?
Sure
Are there any user-facing changes?
Nah