Skip to content

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Sep 22, 2025

Rationale for this change

Don't need base pipe

What changes are included in this PR?

Update package to use native pipe

Are these changes tested?

Sure

Are there any user-facing changes?

Nah

Copy link

⚠️ GitHub issue #47106 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic marked this pull request as ready for review September 24, 2025 06:16
@thisisnic thisisnic requested a review from jonkeane as a code owner September 24, 2025 06:16
@thisisnic thisisnic requested a review from amoeba September 30, 2025 15:03
@amoeba
Copy link
Member

amoeba commented Oct 6, 2025

@github-actions crossbow submit -g r

Copy link

github-actions bot commented Oct 6, 2025

Revision: 6892a21

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c305d6d3e

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change feels pretty safe but I thought I'd kick off crossbow jobs just in case. Thanks for taking this on @thisisnic.

@amoeba
Copy link
Member

amoeba commented Oct 6, 2025

Looks like nightly libarrow for R isn't being built and we may need to add an override in the script for test-r-rhub-debian-gcc-release-custom-ccache to run correctly until rhub/debian-gcc-release is updated.

@amoeba amoeba merged commit 48a2e88 into apache:main Oct 6, 2025
11 checks passed
@amoeba amoeba removed the awaiting committer review Awaiting committer review label Oct 6, 2025
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 48a2e88.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants