-
Notifications
You must be signed in to change notification settings - Fork 982
Update release instructions to not push tags until release is approved #7754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−28
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
10526c4
Update release instructions to not push tags until release is approved
alamb ebdc81c
Update dev/release/README.md
alamb e9e8cb4
revert changes to create-tarball.sh
alamb 3084469
Update create release candidate script
alamb dbfa5be
Merge remote-tracking branch 'apache/main' into alamb/update_release_…
alamb c7866e9
prettier
alamb 8068e96
Update dev/release/README.md
alamb 597a8c3
move order
alamb 2ae7b74
Merge remote-tracking branch 'apache/main' into alamb/update_release_…
alamb 4276cb6
Merge branch 'alamb/update_release_instructions2' of github.com:alamb…
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,13 +45,14 @@ SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | |
SOURCE_TOP_DIR="$(cd "${SOURCE_DIR}/../../" && pwd)" | ||
|
||
if [ "$#" -ne 2 ]; then | ||
echo "Usage: $0 <tag> <rc>" | ||
echo "Usage: $0 <version> <rc>" | ||
echo "ex. $0 4.1.0 2" | ||
exit | ||
fi | ||
|
||
tag=$1 | ||
version=$1 | ||
rc=$2 | ||
tag="${version}-rc${rc}" | ||
|
||
|
||
# mac tar doesn't have --delete, so use gnutar | ||
|
@@ -64,9 +65,12 @@ else | |
tar=tar | ||
fi | ||
|
||
release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag}) | ||
if ! git -C "${SOURCE_TOP_DIR}" rev-list --max-count=1 ${tag}; then | ||
echo "Cannot continue: unknown git tag: $tag" | ||
fi | ||
|
||
|
||
release=apache-arrow-rs-${tag} | ||
release=apache-arrow-rs-${version} | ||
distdir=${SOURCE_TOP_DIR}/dev/dist/${release}-rc${rc} | ||
tarname=${release}.tar.gz | ||
tarball=${distdir}/${tarname} | ||
|
@@ -75,22 +79,18 @@ url="https://dist.apache.org/repos/dist/dev/arrow/${release}-rc${rc}" | |
echo "Attempting to create ${tarball} from tag ${tag}" | ||
|
||
|
||
if [ -z "$release_hash" ]; then | ||
echo "Cannot continue: unknown git tag: $tag" | ||
fi | ||
|
||
echo "Draft email for [email protected] mailing list" | ||
echo "" | ||
echo "---------------------------------------------------------" | ||
cat <<MAIL | ||
To: [email protected] | ||
Subject: [VOTE][RUST] Release Apache Arrow Rust ${tag} RC${rc} | ||
Subject: [VOTE][RUST] Release Apache Arrow Rust ${version} RC${rc} | ||
|
||
Hi, | ||
|
||
I would like to propose a release of Apache Arrow Rust Implementation, version ${tag}. | ||
|
||
This release candidate is based on commit: ${release_hash} [1] | ||
This release candidate is based on commit: ${tag} [1] | ||
|
||
The proposed release tarball and signatures are hosted at [2]. | ||
|
||
|
@@ -106,22 +106,21 @@ The vote will be open for at least 72 hours. | |
[ ] +0 | ||
[ ] -1 Do not release this as Apache Arrow Rust ${version} because... | ||
|
||
[1]: https://github.com/apache/arrow-rs/tree/${release_hash} | ||
[1]: https://github.com/apache/arrow-rs/tree/${tag} | ||
[2]: ${url} | ||
[3]: https://github.com/apache/arrow-rs/blob/${release_hash}/CHANGELOG.md | ||
[4]: https://github.com/apache/arrow-rs/blob/main/dev/release/verify-release-candidate.sh | ||
[3]: https://github.com/apache/arrow-rs/blob/${tag}/CHANGELOG.md | ||
[4]: https://github.com/apache/arrow-rs/blob/master/dev/release/verify-release-candidate.sh | ||
echo "---------------------------------------------------------" | ||
|
||
|
||
|
||
# create <tarball> containing the files in git at $release_hash | ||
# the files in the tarball are prefixed with {tag} (e.g. 4.0.1) | ||
# use --delete to filter out `object_store` files | ||
# create <tarball> containing the files in git at $tag | ||
# the files in the tarball are prefixed with {release} | ||
# (e.g. apache-arrow-rs-4.0.1) | ||
mkdir -p ${distdir} | ||
(cd "${SOURCE_TOP_DIR}" && \ | ||
git archive ${release_hash} --prefix ${release}/ \ | ||
| $tar --delete ${release}/'object_store' \ | ||
git archive ${tag} --prefix ${release}/ \ | ||
| gzip > ${tarball}) | ||
|
||
echo "Running rat license checker on ${tarball}" | ||
|
@@ -138,4 +137,4 @@ gpg --armor --output ${tarball}.asc --detach-sig ${tarball} | |
echo "Uploading to apache dist/dev to ${url}" | ||
svn co --depth=empty https://dist.apache.org/repos/dist/dev/arrow ${SOURCE_TOP_DIR}/dev/dist | ||
svn add ${distdir} | ||
svn ci -m "Apache Arrow Rust ${tag} ${rc}" ${distdir} | ||
svn ci -m "Apache Arrow Rust ${version} ${rc}" ${distdir} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Pick a Release Candidate (RC) number" -> "Create git tag for the release" order may be better: