Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 23, 2025

Which issue does this PR close?

Rationale for this change

When we push a tag like 55.2.0 to github it now makes a github 'release' (thanks to @kou )

https://github.com/apache/arrow-rs/relea

However we shouldn't make a release until it is officially approved per ASF guidelines to avoid confusion about what constitutes an official release

What changes are included in this PR?

  1. Update release instructions and scripts to postpone pushing the release tag until the release is approved
  2. Update dev/release/create-tarball.sh to use new scheme

Are there any user-facing changes?

Hopefully next release we'll only see releases after the release is approved.

Are the changes tested?

I tested this manually locally and it seems to work well

@alamb alamb added the development-process Related to development process of arrow-rs label Jun 23, 2025
@alamb alamb marked this pull request as ready for review June 23, 2025 21:24
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.

### Pick a Release Candidate (RC) number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Pick a Release Candidate (RC) number" -> "Create git tag for the release" order may be better:

diff --git a/dev/release/README.md b/dev/release/README.md
index 7b2d4f175..e2257b69c 100644
--- a/dev/release/README.md
+++ b/dev/release/README.md
@@ -105,14 +105,14 @@ create a release candidate using the following steps. Note you need to
 be a committer to run these scripts as they upload to the apache `svn`
 distribution servers.
 
-### Create git tag for the release:
-
-While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
-
 ### Pick a Release Candidate (RC) number
 
 Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
 
+### Create git tag for the release:
+
+While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+
 Use a string such as `43.0.0` as the `<version>`.
 
 Create and push the tag thusly (for example, for version `4.1.0` and `rc2` would be `4.1.0-rc2`):

@alamb alamb merged commit d0ef310 into apache:main Jul 1, 2025
9 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jul 1, 2025

Thanks again @kou

@alamb alamb deleted the alamb/update_release_instructions2 branch July 1, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is 55.2.0 an RC or actually released? 🤔
3 participants