Update release instructions to not push tags until release is approved #7754
+34
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jun 23, 2025
dev/release/README.md
Outdated
Comment on lines
112
to
114
| ### Pick an Release Candidate (RC) number | ||
|
|
||
| Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc. |
There was a problem hiding this comment.
Can we move this before ### Create git tag for the release:?
etseidl
reviewed
Jun 23, 2025
kou
approved these changes
Jun 25, 2025
| git push apache <version> | ||
| ``` | ||
|
|
||
| Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-4.1.0/, using the `release-tarball.sh` script: |
There was a problem hiding this comment.
Suggested change
| Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-4.1.0/, using the `release-tarball.sh` script: | |
| Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-rs-4.1.0/, using the `release-tarball.sh` script: |
| @@ -109,21 +109,21 @@ distribution servers. | |||
|
|
|||
| While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology. | |||
|
|
|||
| ### Pick a Release Candidate (RC) number | |||
There was a problem hiding this comment.
"Pick a Release Candidate (RC) number" -> "Create git tag for the release" order may be better:
diff --git a/dev/release/README.md b/dev/release/README.md
index 7b2d4f175..e2257b69c 100644
--- a/dev/release/README.md
+++ b/dev/release/README.md
@@ -105,14 +105,14 @@ create a release candidate using the following steps. Note you need to
be a committer to run these scripts as they upload to the apache `svn`
distribution servers.
-### Create git tag for the release:
-
-While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
-
### Pick a Release Candidate (RC) number
Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
+### Create git tag for the release:
+
+While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+
Use a string such as `43.0.0` as the `<version>`.
Create and push the tag thusly (for example, for version `4.1.0` and `rc2` would be `4.1.0-rc2`):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When we push a tag like
55.2.0to github it now makes a github 'release' (thanks to @kou )https://github.com/apache/arrow-rs/relea
However we shouldn't make a release until it is officially approved per ASF guidelines to avoid confusion about what constitutes an official release
What changes are included in this PR?
dev/release/create-tarball.shto use new schemeAre there any user-facing changes?
Hopefully next release we'll only see releases after the release is approved.
Are the changes tested?
I tested this manually locally and it seems to work well